[Held requests] When partial approving report, long delay creating new report for held expense(s)

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.70-2 Reproducible in staging?: Yes Reproducible in production?: Yes If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: @JmillsExpensify Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1714761240737509

Action Performed:

1. Navigate to a report containing several expenses from someone else
2. Click in the three dot menu in the expense
3. Choose Hold, leave comment
4. Confirm that the expense is on hold (e.g. Hold in the header)
5. Navigate to the report, click Approve
6. Choose Approve only…

Expected Result:

A new report with the held expense is created immediately in the front-end

Actual Result:

A new report with the held expense is created 10+ seconds later

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• [X] Android: Native
• [X] Android: mWeb Chrome
• [X] iOS: Native
• [X] iOS: mWeb Safari
• [X] MacOS: Chrome / Safari
• [X] MacOS: Desktop

Screenshots/Videos

https://github.com/Expensify/App/assets/38435837/2da79e50-ce70-4195-affb-37d1ed617a04

Add any screenshot/video evidence

View all open jobs on GitHub

[melvin-bot[bot]]

Triggered auto assignment to @kevinksullivan (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[JmillsExpensify]

After speaking internally, we landed on the following solution:

• Optimistically create the report
• Use the "pending" pattern as long as the user is offline
• Set the report total/currency optimistically to the first expense on the report
• Message in subsequent expense previews to correctly reflect that the report total will be updated when the user comes online
• Update X expenses on the report preview to correctly reflect the number of expenses on the report

We already employ this solution for IOU reports but we need to update expense reports to bring them in line and do the same thing.

[JmillsExpensify]

Screenshots for clarity

Report created optimistically with multiple currencies

Report preview appropriately showing 2 expenses

[JmillsExpensify]

Based on a Slack convo, I think that @war-in might be interested in this issue?

[nkdengineer]

@JmillsExpensify This bug is the same as https://github.com/Expensify/App/issues/39338. I think we should re-open the original issue.

[war-in]

Based on a Slack convo, I think that @war-in might be interested in this issue?

Yes, I would like to take this one

[trjExpensify]

@war-in are you good to prioritise putting up a PR for this one?

[trjExpensify]

@nkdengineer @robertjchen I'm going to assign you both to ultimately review the PR. 👍

[war-in]

Yes, however, I work part-time and will be available on Friday. Is that okay with you?

[melvin-bot[bot]]

@robertjchen, @kevinksullivan, @war-in, @nkdengineer Eep! 4 days overdue now. Issues have feelings too...

[robertjchen]

In progress/Discussions on Slack

[war-in]

Hi @robertjchen 👋 Contacting you there because I was removed from the #expensify-bugs channel 😢 My current progress looks like that

https://github.com/Expensify/App/assets/61014013/66621ff5-91dc-4535-ae86-cea62ac7bfb3

It's not finished yet but would be nice to get an endpoint which accepts the reportID parameter and does not create a new one. Do you have an ETA for it? Or maybe such an endpoint already exists?