search

Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
2.99k stars 2.5k forks source link

Approve modal does not appear when one of the expense is held #41655

Open m-natarajan opened 1 week ago

m-natarajan commented 1 week ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: Reproducible in staging?: Needs reproduction Reproducible in production?: Needs reproduction If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: @puneetlath Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1714845351600779

Action Performed:

  1. Go to staging.new.expensify.com
  2. As an employee submit two expenses to approver
  3. Login as approver and open the report
  4. Open one of the expense and hold it.
  5. Click back to report
  6. Click approve button at the top of the page

Expected Result:

Modal prompt to decide to approve the held or unheld total

Actual Result:

No modal displayed and both expense got approved.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/Expensify/App/assets/38435837/a0db747a-a37f-432c-9b99-13cf5cb1ade1

View all open jobs on GitHub

melvin-bot[bot] commented 1 week ago

Triggered auto assignment to @stephanieelliott (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

MelvinBot commented 1 week ago

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

stephanieelliott commented 1 week ago

I'm not able to reproduce this, adding the label to get it on the weekly retest rotation.

puneetlath commented 1 week ago

I experience it about 50% of the time when I try to approve with held expenses.

mvtglobally commented 5 days ago

Issue not reproducible during KI retests. (First week)

stephanieelliott commented 2 days ago

Still trying to repro, I think there is a proposal in the works to create jobs for these so will keep an eye there bc I do think this is worth fixing.