Closed mananjadhav closed 1 week ago
@fedirjh Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]
### Fixed Issues
section aboveTests
sectionQA steps
sectiontoggleReport
and not onIconClick
).myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components using Avatar
have been tested & I retested again)/** comment above it */
this
properly so there are no scoping issues (i.e. for onClick={this.submit}
the method this.submit
should be bound to this
in the constructor)this
are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this);
if this.submit
is never passed to a component event handler like onClick
)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG
)Avatar
is modified, I verified that Avatar
is working as expected in all cases)Design
label and/or tagged @Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test
steps.:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.
🚀 Deployed to production by https://github.com/marcaaron in version: 1.4.71-6 🚀
platform | result |
---|---|
🤖 android 🤖 | success ✅ |
🖥 desktop 🖥 | success ✅ |
🍎 iOS 🍎 | success ✅ |
🕸 web 🕸 | success ✅ |
Details
The disconnect Xero wasn't working as expected. Fixed the Xero disconnect. Also we don't need the failureData for the API call so removed it.
Fixed Issues
$ https://github.com/Expensify/App/issues/39726 PROPOSAL:
Tests
Pre-requisite:
Disconnect
button.Disconnect
and you should see theXero
option shows themenu
button.policy_policyID?.connections
is{}
.Offline tests
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
https://github.com/Expensify/App/assets/3069065/216954cd-e3ca-4bbe-86a6-2cdcb3ddf20bAndroid: mWeb Chrome
https://github.com/Expensify/App/assets/3069065/05cacbd1-4724-4d57-8793-d6198e22928eiOS: Native
https://github.com/Expensify/App/assets/3069065/cd829028-a86b-4209-a5d4-dc31cbfec9afiOS: mWeb Safari
https://github.com/Expensify/App/assets/3069065/75c9d5b5-bce4-407b-965a-c2c37e22d7bcMacOS: Chrome / Safari
https://github.com/Expensify/App/assets/3069065/c69d42ea-9819-4a08-b4ac-9d5e0c4b3efaMacOS: Desktop
https://github.com/Expensify/App/assets/3069065/453216d6-b169-4df6-be51-e522db60a6a4