Closed nkdengineer closed 1 week ago
Hey! I see that you made changes to our Form component. Make sure to update the docs in FORMS.md accordingly. Cheers!
@dannymcclain @eh2077 One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]
In the previous PR I was missing some imports Please check again @eh2077 @marcaaron
That's weird that this wasn't caught by CI - Lint code / Run ESLint (pull_request)
. I believe @marcaaron should have checked All checks have passed
before merging.
I saw the last lint check of the previous PR was passed
Click this link to see lint check records https://github.com/Expensify/App/actions/workflows/lint.yml?query=actor%3Ankdengineer+branch%3Afix%2F40313
@nkdengineer Can you help to check locally if npm run lint
can catch these missing imports?
@eh2077 in my locally npm run lint
can't catch these missing imports
@eh2077 in my locally
npm run lint
can't catch these missing imports
Ok. npm run typecheck
also can't catch this, see https://github.com/Expensify/App/actions/workflows/typecheck.yml?query=actor%3Ankdengineer+branch%3Afix%2F40313
I think this should be a potential improvements for lint or typecheck or both
### Fixed Issues
section aboveTests
sectionQA steps
sectiontoggleReport
and not onIconClick
).myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components using Avatar
have been tested & I retested again)/** comment above it */
this
properly so there are no scoping issues (i.e. for onClick={this.submit}
the method this.submit
should be bound to this
in the constructor)this
are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this);
if this.submit
is never passed to a component event handler like onClick
)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG
)Avatar
is modified, I verified that Avatar
is working as expected in all cases)Design
label and/or tagged @Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test
steps.π Deployed to production by https://github.com/marcaaron in version: 1.4.71-6 π
platform | result |
---|---|
π€ android π€ | success β |
π₯ desktop π₯ | success β |
π iOS π | success β |
πΈ web πΈ | success β |
Details
Fixed Issues
$ https://github.com/Expensify/App/issues/40313 PROPOSAL:
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop