[HOLD for payment 2024-07-24] [$250] [Uneven Splits] [Polish] Android - Split amount is not reset when tapping Reset button when keyboard is up

Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.

https://new.expensify.com

MIT License

3.3k stars 2.73k forks source link

[HOLD for payment 2024-07-24] [$250] [Uneven Splits] [Polish] Android - Split amount is not reset when tapping Reset button when keyboard is up #41763

Closed m-natarajan closed 1 month ago

m-natarajan commented 4 months ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.4.71-0 Reproducible in staging?: y Reproducible in production?: new feature If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: Applause internal team Slack conversation:

Action Performed:

Launch New Expensify app.
Go to FAB > Split expense.
Enter amount and select a few users.
Tap on split amount input.
Manually enter the split amount.
With keyboard up, tap on Reset button.

Expected Result:

The split amount will be reset (mweb behavior when keyboard is up).

Actual Result:

The keyboard is dismissed and the split amount is not reset.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android: Native
[ ] Android: mWeb Chrome
[x] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/Expensify/App/assets/38435837/bc3628b3-3d50-4a64-aff8-c68eef43c839

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~010af563a3cc74c7c2
Upwork Job ID: 1787911203897004032
Last Price Increase: 2024-05-28

Issue Owner

Current Issue Owner: @alexpensify

kaushiktd commented 3 months ago

@youssef-lr A PR for another issue is already in progress and PR is not merged yet so how can I create new PR without affecting that PR? I am not able to see fork option because that one is still in progress.

isabelastisser commented 3 months ago

Bump @eVoloshchak and @youssef-lr to see @kaushiktd comments above. Thanks!

youssef-lr commented 3 months ago

@kaushiktd sorry I'm not following, what other PR is open? does it fix this issue?

youssef-lr commented 3 months ago

A PR for another issue is already in progress and PR is not merged yet so how can I create new PR without affecting that PR?

Ah I think I see, is this about our guidelines to only have one PR in progress?

kaushiktd commented 3 months ago

@youssef-lr I've already submitted PR for this issue and tagged @eVoloshchak there. Do you want to me to tag you there as well?

kaushiktd commented 3 months ago

@youssef-lr Yes but I got it sorted from slack.

melvin-bot[bot] commented 2 months ago

This issue has not been updated in over 15 days. @eVoloshchak, @youssef-lr, @isabelastisser, @kaushiktd eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

isabelastisser commented 2 months ago

@eVoloshchak @youssef-lr @kaushiktd, what's next here? Is the PR on hold?

kaushiktd commented 2 months ago

@isabelastisser PR is ready. Waiting for @eVoloshchak review.

isabelastisser commented 2 months ago

Thanks, @kaushiktd! @eVoloshchak, please review the PR. I will DM you for visibility. Thanks!

isabelastisser commented 1 month ago

@eVoloshchak @kaushiktd please provide an update, thanks!

kaushiktd commented 1 month ago

@isabelastisser working on new PR

melvin-bot[bot] commented 1 month ago

Reviewing label has been removed, please complete the "BugZero Checklist".

melvin-bot[bot] commented 1 month ago

The solution for this issue has been :rocket: deployed to production :rocket: in version 9.0.7-8 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

https://github.com/Expensify/App/pull/42897

If no regressions arise, payment will be issued on 2024-07-24. :confetti_ball:

For reference, here are some details about the assignees on this issue:

@eVoloshchak requires payment through NewDot Manual Requests
@kaushiktd requires payment (Needs manual offer from BZ)

melvin-bot[bot] commented 1 month ago

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[ ] [@eVoloshchak] The PR that introduced the bug has been identified. Link to the PR:
[ ] [@eVoloshchak] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[ ] [@eVoloshchak] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[ ] [@eVoloshchak] Determine if we should create a regression test for this bug.
[ ] [@eVoloshchak] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[ ] [@isabelastisser] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

melvin-bot[bot] commented 1 month ago

Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

melvin-bot[bot] commented 1 month ago

Triggered auto assignment to @alexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

isabelastisser commented 1 month ago

I will be OOO tomorrow and next week, so I am reassigning this until I return on July 29. Thanks, @alexpensify

Status:

@eVoloshchak needs to complete the BZ list.
Payment is due on July 24.

alexpensify commented 1 month ago

Noted, I'll prepare next week for the payment date.

alexpensify commented 1 month ago

Not overdue, the payment date is on the 24th.

melvin-bot[bot] commented 1 month ago

Payment Summary

Upwork Job

Reviewer: @eVoloshchak owed $250 via NewDot
ROLE: @kaushiktd paid $250 via Upwork

BugZero Checklist (@alexpensify)

[x] I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
[x] I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1787911203897004032/hired)
[x] I have paid out the Upwork contracts or cancelled the ones that are incorrect
[x] I have verified the payment summary above is correct

alexpensify commented 1 month ago

Correct me if I'm wrong, but it looks like there is another PR in the works associated with this GH: https://github.com/Expensify/App/pull/45333. I'm going to hold off on completing the payment action until all PRs are in production.

@kaushiktd - please apply here: https://www.upwork.com/jobs/~016c93f917170cbc76

Thanks!

kaushiktd commented 1 month ago

@alexpensify Is it possible for you to send me an invitation to that job?

alexpensify commented 1 month ago

@kaushiktd - I sent an invite via Upwork. Please accept and I can complete the payment process. Thanks!

kaushiktd commented 1 month ago

Thank you @alexpensify

I accepted the offer.

alexpensify commented 1 month ago

Done - I've completed the payment process in Upwork

https://github.com/Expensify/App/issues/41763#issuecomment-2248625040

@eVoloshchak - please submit a request in Chat, thanks!

isabelastisser commented 1 month ago

Thanks for handling this, @alexpensify!

alexpensify commented 1 month ago

You're welcome! @isabelastisser there is no more action to take here.

@eVoloshchak - please submit a request in Chat. Thanks!