Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
2.99k stars 2.5k forks source link

[$250] Group chat - LHN preview shows "made admin" while there is no system message in group chat #41837

Open lanitochka17 opened 1 week ago

lanitochka17 commented 1 week ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.71-0 Reproducible in staging?: Y Reproducible in production?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: N/A Issue reported by: Applause - Internal Team

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to FAB > Start chat
  3. Create a group chat
  4. Send a message to the group chat
  5. Click on chat header > Members
  6. Promote a member to admin
  7. Note that group chat preview in LHN is the message sent in Step 4
  8. Send a message to another chat
  9. Go to Account settings > Troubleshoot
  10. Select Clear cache and restart
  11. After the app is restarted, note the group chat preview in LHN

Expected Result:

The group chat preview in LHN will follow the latest message sent in the group chat

Actual Result:

The group chat preview in LHN shows system message for making member admin after the app is restarted, while there is no system message in the group chat

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/Expensify/App/assets/78819774/f491dded-818e-42ab-8374-36d128a0562e

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01d089c025af3fea83
  • Upwork Job ID: 1790556079306735616
  • Last Price Increase: 2024-05-15
Issue OwnerCurrent Issue Owner: @jayeshmangwani
melvin-bot[bot] commented 1 week ago

Triggered auto assignment to @anmurali (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

lanitochka17 commented 1 week ago

@anmurali FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

melvin-bot[bot] commented 6 days ago

@anmurali Eep! 4 days overdue now. Issues have feelings too...

melvin-bot[bot] commented 4 days ago

Job added to Upwork: https://www.upwork.com/jobs/~01d089c025af3fea83

melvin-bot[bot] commented 4 days ago

Triggered auto assignment to Contributor-plus team member for initial proposal review - @jayeshmangwani (External)

anmurali commented 4 days ago
image

This is odd cause the message shows up only in LHN but not in the room!

MrMuzyk commented 2 days ago

I am Michał from Callstack - expert contributor group. I’d like to work on this job.

MrMuzyk commented 2 days ago

I've managed to reproduce that. Can you specify what expected result should be here?

Should we display message about making a new admin in chat and LHN is previewing the message correctly or should we preview last message send in chat and ignore info about making a new admin - so LHN is previewing message incorrectly?