Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
2.99k stars 2.5k forks source link

[$250] Android - Send invoice - In conversation page, transaction preview shown briefly and disappeared #41839

Open lanitochka17 opened 1 week ago

lanitochka17 commented 1 week ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.71 Reproducible in staging?: Y Reproducible in production?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: N/A Issue reported by: Applause - Internal Team

Action Performed:

  1. Launch app
  2. Tap fab --- send invoice
  3. Enter an amount and tap next
  4. Select a contact
  5. Tap send invoice

Expected Result:

In send invoice conversation page, transaction preview must not be shown briefly and disappeared

Actual Result:

In send invoice conversation page, transaction preview shown briefly and disappeared

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/Expensify/App/assets/78819774/f060fa77-cfb8-4ab6-a9eb-5aa3726a8326

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~014e2c68306bbf442b
  • Upwork Job ID: 1788235320335278080
  • Last Price Increase: 2024-05-08
melvin-bot[bot] commented 1 week ago

Triggered auto assignment to @lschurr (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

lanitochka17 commented 1 week ago

@lschurr FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

lanitochka17 commented 1 week ago

We think that this bug might be related to #wave-collect - Release 1

melvin-bot[bot] commented 1 week ago

Job added to Upwork: https://www.upwork.com/jobs/~014e2c68306bbf442b

melvin-bot[bot] commented 1 week ago

Triggered auto assignment to Contributor-plus team member for initial proposal review - @dukenv0307 (External)

james-tindal commented 1 week ago

Root cause

In the server's response to SendInvoice, the disappearing ReportAction has an empty message.

Solution

Server

reportAction.message[0].html and reportAction.message[0].text should be non-empty strings.

Front-end

This can be worked-around by adding the message to the successData on the front-end.

melvin-bot[bot] commented 1 week ago

Current assignee @dukenv0307 is eligible for the Internal assigner, not assigning anyone new.

cristipaval commented 1 week ago

We knew about this issue and we're working internally on it

melvin-bot[bot] commented 6 days ago

@cristipaval, @lschurr, @dukenv0307 Whoops! This issue is 2 days overdue. Let's get this updated quick!

lschurr commented 6 days ago

Any update @cristipaval?

cristipaval commented 5 days ago

^fix PR up