Closed lanitochka17 closed 5 days ago
Triggered auto assignment to @MitchExpensify (Bug
), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.
@MitchExpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
We think that this bug might be related to #wave-collect - Release 1
The one moment loader appears every time completing a sub-step of personal info. This happens in company/business info too.
This happens after this PR where we save each sub-step data. Every time we save a substep, we set the loading data to true. https://github.com/Expensify/App/blob/e0b6a06d2f34f35cda96ccc4d05252ede111c732/src/libs/actions/BankAccounts.ts#L137-L139
The loading data will then show the one moment loading indicator as shown below. https://github.com/Expensify/App/blob/e0b6a06d2f34f35cda96ccc4d05252ede111c732/src/pages/ReimbursementAccount/ReimbursementAccountPage.tsx#L391-L396
The reason this only happens in Android is because shouldReopenOnfido
is true for Android but false for other platforms. The comment above explains why.
https://github.com/Expensify/App/blob/e0b6a06d2f34f35cda96ccc4d05252ede111c732/src/libs/shouldReopenOnfido/index.android.ts#L3
If we are saving a sub-step data, don't set the loading data to true. We can pass the isConfirmPage
from updatePersonalInformationForBankAccount
to getVBBADataForOnyx
.
https://github.com/Expensify/App/blob/e0b6a06d2f34f35cda96ccc4d05252ede111c732/src/libs/actions/BankAccounts.ts#L286-L297
Then, set the loading state to true if isConfirmPage
is true.
https://github.com/Expensify/App/blob/e0b6a06d2f34f35cda96ccc4d05252ede111c732/src/libs/actions/BankAccounts.ts#L139
function getVBBADataForOnyx(currentStep?: BankAccountStep, shouldSetLoading = true): OnyxData {
return {
optimisticData: [
{
onyxMethod: Onyx.METHOD.MERGE,
key: ONYXKEYS.REIMBURSEMENT_ACCOUNT,
value: {
isLoading: shouldSetLoading,
errors: null,
},
},
],
We should probably wait for the performance issues to die down before resting this but I agree the copy is a bit weird regardless of the loader showing after every step. Even then this doesn't seem buggy to me, its just a loading pattern when we are loading/saving data
@MitchExpensify hi, I believe this is a buggy behavior.
I think the loading should only show when moving between steps 1 -> 2 just like it was before https://github.com/Expensify/App/pull/37680
Reopening to investigate further
@MitchExpensify looks like it gets closed again unintentionally.
I reproduced this but I just don't feel like its worth fixing right now
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 1.4.71-0 Reproducible in staging?: Y Reproducible in production?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: N/A Email or phone of affected tester (no customers): applausetester+ck0205@applause.expensifail.com Issue reported by: Applause - Internal Team
Action Performed:
Precondition: Workspace created and enables Workflows in More features
Expected Result:
One moment loader should not appear after every step while entering personal info
Actual Result:
One moment loader appears after every step while entering Personal info DOB page appears briefly after providing FN/LN, then immediately one moment loader is seen & this happens after DOB, SSN & address steps
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
https://github.com/Expensify/App/assets/78819774/1056aba6-8797-47f7-bf8d-9c201dcad5b6
View all open jobs on GitHub