search

Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
2.99k stars 2.5k forks source link

[HOLD #38702] Update avatars depending on the number of requestors on the report #41873

Open NikkiWines opened 1 week ago

NikkiWines commented 1 week ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

*Version Number: v1.4.70-5 Reproducible in staging?: Y Reproducible in production?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: N/A Email or phone of affected tester (no customers): N/A Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: N/A Issue reported by: @shawnborton Slack conversation: N/A discussion here

Coming from this issue. Align our icon usage (and ensure that the icon and personal details are loading correctly) for the report preview, report, and transaction thread.

Action Performed:

1:1 IOU with requests from a single user

  1. Create a chat with another user
  2. Make one (or multiple) money requests to the user from your current account

1:1 IOU with requests from both users

  1. Create a chat with another user
  2. Request money from them
  3. Have them request money from you

Workspace chat

  1. Log into an Expensify account
  2. Create a new workspace
  3. Navigate to the workspace chat and make one (or multiple) money request

Expected Result:

1:1 IOU with requests from a single user

  1. We use a single-user avatar for the report preview on the chat, the report header, and the transaction thread header CleanShot 2024-05-03 at 07 57 21@2x

1:1 IOU with requests from multiple user

  1. We use a dual-diagonal-user avatar for the report preview on the chat, the report header, and the transaction thread header CleanShot 2024-05-03 at 07 58 12@2x

Workspace Chat

  1. We use a large-user-small-workspace avatar for the report preview on the chat, the report header, and the transaction thread header CleanShot 2024-05-03 at 08 05 28@2x

Actual Result:

1:1 IOU with requests from a single user and 1:1 IOU with requests from multiple user

  1. We occasionally show default avatars without personal details for the report preview. When personal details do load, we display the diagonal-dual-user avatar. image image

For the report itself, we display either the diagonal-dual-user or single-user avatar on the report level depending on whether or not the expense has multiple expenses or only one expense.

image image

Workspace Chat

  1. We occasionally show default avatars without personal details for the report preview. When personal details do load, we display the diagonal-dual-user avatar. image image

For the report itself, we correctly display the large-user-small-workspace avatar

image

Workaround:

N/A this doesn't impact the ability to use the app

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

View all open jobs on GitHub

melvin-bot[bot] commented 1 week ago

Triggered auto assignment to @garrettmknight (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

NikkiWines commented 1 week ago

Holding per the discussion in #38702