[HOLD for payment 2024-07-29][$250] Chat - Live markdown preview for Heading is not shown in the composer if space exist before

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.72-0 Reproducible in staging?: y Reproducible in production?: y If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4547651 Issue reported by: Applause - Internal Team

Action Performed:

1. Open ND Expensify
2. Navigate to any Chat
3. Enter a space and a header markdown text for example " space # Header "
4. Verify the preview
5. Send the text
6. Verify the message is shown as heading markdown

Expected Result:

Live markdown preview for Heading (inside the composer) is shown if space is used before

Actual Result:

If space is used before, Live Markdown preview for heading (inside the composer) is not shown. But it is correctly shown after the message is sent. Note: -It is ok that if a character (except space) is used before, live markdown is not shown because the heading is not applied even after the message is sent. -The same issue occurs also for Quotes markdown >

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• [x] Android: Native
• [x] Android: mWeb Chrome
• [ ] iOS: Native
• [ ] iOS: mWeb Safari
• [x] MacOS: Chrome / Safari
• [ ] MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/Expensify/App/assets/93399543/921be3b0-bc4a-42f2-b784-970ca2438913

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01e69db88132b2d1b4
• Upwork Job ID: 1788634876612800512
• Last Price Increase: 2024-05-30
• Automatic offers:
• badeggg | Contributor | 102592680

[melvin-bot[bot]]

@badeggg, @sonialiap, @luacmartins, @allroundexperts Whoops! This issue is 2 days overdue. Let's get this updated quick!

[luacmartins]

PR is in review

[thienlnam]

I took another look at the issue we're trying to solve, and think that that removing trimming whitespace from text inputs to solve this is actually a worse tradeoff.

I did this same markdown test in Discord and the same issue exists there https://github.com/Expensify/App/assets/30609178/0da4491c-7324-4c86-9dcb-17f451003cae

After a second though, it seems like opening up a bunch of pre-pending or ending white space is not what we want to end up doing here as any messages like below would be sent

   dkalwlkdwakl wda
   dwakodwakadwo 

  dwakodwakodwa 

I know others felt otherwise above, but curious for your thoughts? @dannymcclain / @dubielzyk-expensify

[luacmartins]

@Expensify/design bump on the above

[dannymcclain]

Dang I'm honestly a bit stumped about this one.

[shawnborton]

@thienlnam what would your recommendation be then? I'm also starting to feel a bit lost on this one.

[thienlnam]

Just to do nothing for this issue - the only problem that exists is if we start a message with spaces and add a header, the composer doesn't show it in live markdown, and if the trade-off is removing all whitespace stripping from the beginning of the message it doesn't seem worth it to solve that bug

    # Header

[dannymcclain]

if the trade-off is removing all whitespace stripping from the beginning of the message it doesn't seem worth it to solve that bug

Ok yeah, I agree with this and am fine with doing nothing.

[luacmartins]

Ok, seems like we agree that we should do nothing and just close this then.

[thienlnam]

Great, it seems we are in agreement on this. Let's also offer partial compensation like 50% for the pull requests since considerable effort was put into finding a solution, even though we ultimately chose a different direction.

[shawnborton]

Works for me too, thanks for all of the discussion and effort put into this one!

[melvin-bot[bot]]

This issue has not been updated in over 15 days. @badeggg, @sonialiap, @luacmartins, @allroundexperts eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[thienlnam]

cc @sonialiap Could you please do payments for this based on https://github.com/Expensify/App/issues/41908#issuecomment-2194968151 so we can close this out?

[luacmartins]

Bump @sonialiap

[sonialiap]

Payment summary: Per this comment https://github.com/Expensify/App/issues/41908#issuecomment-2194968151 paying 50% for effort put into resolving this before it was closed

• @badeggg $125 - offer sent in upwork (job link) - paid ✔️
• @allroundexperts $125 - please request in ND

[JmillsExpensify]

$125 approved for @allroundexperts