[HOLD for payment 2024-07-17] [Details Revamp] Remove the Three Dot Menu on Affected Reports - Githubissues

Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.

https://new.expensify.com

MIT License

3.34k stars 2.77k forks source link

[HOLD for payment 2024-07-17] [Details Revamp] Remove the Three Dot Menu on Affected Reports #42080

Closed grgia closed 1 month ago

grgia commented 4 months ago

https://docs.google.com/document/d/1-xSZdSZZIuIl0fPO7yypkKfcbWEsnNFAs50ptgL3Gnw/edit#bookmark=id.qn5rgvv8le7q

Issue Owner

Current Issue Owner: @adelekennedy

melvin-bot[bot] commented 4 months ago

Triggered auto assignment to @adelekennedy (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

melvin-bot[bot] commented 4 months ago

:warning: It looks like this issue is labelled as a New Feature but not tied to any GitHub Project. Keep in mind that all new features should be tied to GitHub Projects in order to properly track external CAP software time :warning:

melvin-bot[bot] commented 4 months ago

Triggered auto assignment to Design team member for new feature review - @dannymcclain (NewFeature)

adelekennedy commented 4 months ago

still on hold

adelekennedy commented 3 months ago

@grgia @dannymcclain I assume we're still holding here?

dannymcclain commented 3 months ago

I think that's right. @grgia can confirm!

grgia commented 3 months ago

@cdOut

cdOut commented 3 months ago

This is the final issue and will be on hold until we get this PR merged.

adelekennedy commented 3 months ago

Still waiting for the linked PR to be merged

trjExpensify commented 2 months ago

Can we remove the hold here?

grgia commented 2 months ago

Yep done, @trjExpensify

parasharrajat commented 2 months ago

@trjExpensify Need access to the doc.

parasharrajat commented 2 months ago

Please assign me as C+.

melvin-bot[bot] commented 2 months ago

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

melvin-bot[bot] commented 2 months ago

Reviewing label has been removed, please complete the "BugZero Checklist".

melvin-bot[bot] commented 2 months ago

The solution for this issue has been :rocket: deployed to production :rocket: in version 9.0.5-13 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

https://github.com/Expensify/App/pull/44025

If no regressions arise, payment will be issued on 2024-07-17. :confetti_ball:

For reference, here are some details about the assignees on this issue:

@parasharrajat requires payment through NewDot Manual Requests

melvin-bot[bot] commented 2 months ago

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[ ] [@parasharrajat] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
[ ] [@adelekennedy] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

melvin-bot[bot] commented 2 months ago

The solution for this issue has been :rocket: deployed to production :rocket: in version 9.0.6-8 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

https://github.com/Expensify/App/pull/44025

If no regressions arise, payment will be issued on 2024-07-22. :confetti_ball:

For reference, here are some details about the assignees on this issue:

@parasharrajat requires payment through NewDot Manual Requests

melvin-bot[bot] commented 2 months ago

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[ ] [@parasharrajat] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
[ ] [@adelekennedy] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

adelekennedy commented 2 months ago

Payouts due:

[x] Contributor+: $250 @parasharrajat (NewDot)

adelekennedy commented 1 month ago

@parasharrajat I think the only additional step is the checklist and then we can close this one out?

parasharrajat commented 1 month ago

Regression Test Steps

Create a workspace
Go into a room of said workspace and confirm that the three dot menu in the header is missing
Create two expenses for the workspace
Go into the report view containing both those expenses and confirm the three dot menu is missing
Go into one of the expenses and confirm that the three dot menu is missing
If you have an access to an account with a Concierge guide assigned, please check whether the button for Book a call works properly, since it has been removed from the three dot menu in that chat.

Do you agree 👍 or 👎 ?

adelekennedy commented 1 month ago

@grgia for your thoughts on the above but that makes sense to me!

adelekennedy commented 1 month ago

https://github.com/Expensify/Expensify/issues/415258

parasharrajat commented 1 month ago

Payment requested as per https://github.com/Expensify/App/issues/42080#issuecomment-2240617234

JmillsExpensify commented 1 month ago

$250 approved for @parasharrajat