Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.42k stars 2.8k forks source link

[Snyk] Security upgrade eslint-plugin-jest from 24.7.0 to 25.0.4 #42110

Closed melvin-bot[bot] closed 1 month ago

melvin-bot[bot] commented 4 months ago

This PR was automatically created by Snyk using the credentials of a real user.


Snyk has created this PR to fix one or more vulnerable packages in the `npm` dependencies of this project.

#### Changes included in this PR - Changes to the following files to upgrade the vulnerable dependencies to a fixed version: - package.json
⚠️ Warning ``` Failed to update the package-lock.json, please update manually before merging. ```
#### Vulnerabilities that will be fixed ##### With an upgrade: Severity | Issue | Breaking Change | Exploit Maturity :-------------------------:|:-------------------------|:-------------------------|:------------------------- ![high severity](https://res.cloudinary.com/snyk/image/upload/w_20,h_20/v1561977819/icon/h.png "high severity") | Uncontrolled resource consumption
[SNYK-JS-BRACES-6838727](https://snyk.io/vuln/SNYK-JS-BRACES-6838727) | Yes | No Known Exploit ![high severity](https://res.cloudinary.com/snyk/image/upload/w_20,h_20/v1561977819/icon/h.png "high severity") | Inefficient Regular Expression Complexity
[SNYK-JS-MICROMATCH-6838728](https://snyk.io/vuln/SNYK-JS-MICROMATCH-6838728) | Yes | No Known Exploit
Commit messages
Package name: eslint-plugin-jest The new version differs by 39 commits.
  • 8befa12 chore(release): 25.0.4 [skip ci]
  • afad49a fix: update `@ typescript-eslint/experimental-utils` to v5 (#941)
  • b2ed605 chore(release): 25.0.3 [skip ci]
  • bd2c33c fix(valid-expect-in-promise): support awaited promises in arguments (#936)
  • d90a5dc chore(release): 25.0.2 [skip ci]
  • 07d2137 fix(valid-expect-in-promise): support out of order awaits (#939)
  • e731bce chore: add patches to git
  • cbea1d6 refactor(valid-expect-in-promise): remove duplicate check (#938)
  • c171942 chore(deps): lock file maintenance
  • d47fd25 chore(deps): lock file maintenance
  • 4a3caa4 chore(deps): lock file maintenance
  • 1748063 chore(release): 25.0.1 [skip ci]
  • cb87458 fix: specify peer dependency ranges correctly
  • 3a12aec chore(release): 25.0.0 [skip ci]
  • 2dce752 Merge pull request #905 from jest-community/next
  • 1ef8586 chore(release): 25.0.0-next.7 [skip ci]
  • f3e9e9a feat(valid-describe): rename to `valid-describe-callback`
  • b860084 feat(lowercase-name): rename to `prefer-lowercase-title`
  • 3434d9b feat(prefer-to-be-undefined): remove rule
  • 809bcda feat(prefer-to-be-null): remove rule
  • 2a3376f feat: add `prefer-to-be` to style ruleset
  • c5ccdca chore(release): 25.0.0-next.6 [skip ci]
  • 6708bb8 Merge branch 'main' into next
  • 24b6c5d chore(release): 25.0.0-next.5 [skip ci]
See the full diff
Check the changes in this PR to ensure they won't cause issues with your project. ------------ **Note:** *You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.* For more information: 🧐 [View latest project report](https://app.snyk.io/org/expensify/project/a75415c0-01a0-4906-abb8-070d86e05d58?utm_source=github&utm_medium=referral&page=fix-pr) 🛠 [Adjust project settings](https://app.snyk.io/org/expensify/project/a75415c0-01a0-4906-abb8-070d86e05d58?utm_source=github&utm_medium=referral&page=fix-pr/settings) 📚 [Read more about Snyk's upgrade and patch logic](https://support.snyk.io/hc/en-us/articles/360003891078-Snyk-patches-to-fix-vulnerabilities) [//]: # (snyk:metadata:{"prId":"2cc27977-237a-4068-b701-6a424e8fb4b4","prPublicId":"2cc27977-237a-4068-b701-6a424e8fb4b4","dependencies":[{"name":"eslint-plugin-jest","from":"24.7.0","to":"25.0.4"}],"packageManager":"npm","projectPublicId":"a75415c0-01a0-4906-abb8-070d86e05d58","projectUrl":"https://app.snyk.io/org/expensify/project/a75415c0-01a0-4906-abb8-070d86e05d58?utm_source=github&utm_medium=referral&page=fix-pr","type":"auto","patch":[],"vulns":["SNYK-JS-BRACES-6838727","SNYK-JS-MICROMATCH-6838728"],"upgrade":["SNYK-JS-BRACES-6838727","SNYK-JS-MICROMATCH-6838728"],"isBreakingChange":true,"env":"prod","prType":"fix","templateVariants":["updated-fix-title","pr-warning-shown"],"priorityScoreList":[null,null],"remediationStrategy":"vuln"}) --- **Learn how to fix vulnerabilities with free interactive lessons:** 🦉 [Uncontrolled resource consumption](https://learn.snyk.io/lesson/redos/?loc=fix-pr)
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01c54f4257c1162571
  • Upwork Job ID: 1790111678804545536
  • Last Price Increase: 2024-05-13
melvin-bot[bot] commented 4 months ago

This is a Snyk issue. Snyk is a tool that automatically tracks our repositories' dependencies and reports associated security vulnerabilities. It also automatically create PRs to fix these vulnerabilities.

    C+: Please follow these steps to test the linked PR before running through the reviewer checklist:
    - [ ] The first step is to understand the PR: what dependency is it upgrading, for which vulnerability, how it impacts our product & end users.
    - [ ] If the issue is not worth fixing, please add your reasoning in the issue and have the internal engineer review it.
    - [ ] Check the change log (which should be included in the PR description) to see all changes. We want to identify any breaking changes. If it is a minor version bump, it's unlikely that there are any breaking changes.
    - [ ] Test our feature(s) that make use of this package. If it does not work, we should understand what broke it. It is also a good idea to check our main flows to make sure they are not broken that you can add in the checklist screenshots/videos.
melvin-bot[bot] commented 4 months ago

Job added to Upwork: https://www.upwork.com/jobs/~01c54f4257c1162571

melvin-bot[bot] commented 4 months ago

Triggered auto assignment to Contributor Plus for review of internal employee PR - @Pujan92 (Internal)

melvin-bot[bot] commented 4 months ago

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

melvin-bot[bot] commented 3 months ago

This issue has not been updated in over 15 days. @Pujan92 eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

melvin-bot[bot] commented 1 month ago

@Pujan92, this Monthly task hasn't been acted upon in 6 weeks; closing.

If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.