[payment due 8-27][Track Tax] Support tax tracking when categorizing tracked expense

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.73-0 Reproducible in staging?: y Reproducible in production?: no If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: Applause internal team Slack conversation:

Action Performed:

Precondition:

• Workspace has enabled taxes.

1. Go to staging.new.expensify.com
2. Go to FAB > Track expense.
3. Track a manual expense.
4. In 1:1 DM, click Categorize from the whisper.
5. Select a category.
6. On confirmation page, click Show more.

Expected Result:

Tax rate will be populated in the Tax rate row.

Actual Result:

Tax rate row is empty. After the expense is submitted, the Tax rate row in transaction thread shows the selected tax rate.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• [x] Android: Native
• [x] Android: mWeb Chrome
• [x] iOS: Native
• [x] iOS: mWeb Safari
• [x] MacOS: Chrome / Safari
• [x] MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/Expensify/App/assets/38435837/576e9914-ae3d-4f59-a932-b416f9e8e1c1

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0163666547be770dfa
• Upwork Job ID: 1793250352331440128
• Last Price Increase: 2024-05-22

[eh2077]

@Christinadobrzyn Thanks for the ping. I'd like to pay via upwork. Yes, I think we need to add regression test for this issue.

[eh2077]

I'm away from keyboard and I'll complete the checklist asap, thanks 🙏

[Christinadobrzyn]

Thanks @eh2077 I just send you an Upwork offer too.

[sonialiap]

Thanks @Christinadobrzyn ! I'm back from OOO and can take this back, feel free to keep on or unassign yourself

@eh2077 I've approved the payment ✔️ Please complete the checklist once you get a chance :D

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [ ] [@eh2077] The PR that introduced the bug has been identified. Link to the PR:
• [ ] [@eh2077] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [ ] [@eh2077] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [ ] [@eh2077] Determine if we should create a regression test for this bug.
• [ ] [@eh2077] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [ ] [@sonialiap] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[eh2077]

Checklist

• [x] [@eh2077] The PR that introduced the bug has been identified. Link to the PR: I can't a PR directly caused this issue. The task ended up a larger scope than the original issue.
• [x] [@eh2077] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A
• [x] [@eh2077] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
• [x] [@eh2077] Determine if we should create a regression test for this bug. Yes

Regression test

==== Prepare ====

1. Create a workspace

2. Set the workspace default currency to USD if it is not already that

3. Go to "More features" and enable "Distance rates" and "Taxes"

4. Go to "Taxes" and define 3 tax rates:

   • Tax USD40: 40%
   • Tax other currency10: 10%
   • Tax distance25: 25%

5. Still in "Taxes", click in "Settings" in the top and choose the following defaults:

   

6. Verify you end up with a configuration like this:

   

7. Go "Distance rates" and enable "Track tax" in the top right settings

8. Create a distance rate, assign a tax rate to it and input some amount smaller than the rate in "Tax reclaimable on":

==== case 1 ==== 9. In the DM chat with yourself, click "+ > Track expense" and create an expense with the same currency as the workspace currency 10. Wait for the concierge message with actions and click "Categorize it" 11. The RHN should open with the workspace as the only alternative, select the workspace 12. Choose any category from the list 13. In the expense form, click "Show more" 14. Verify that the tax code is set to the default tax code for expenses with the currency of the workspace 15. Verify that the tax amount looks correct 16. Change the tax code manually 17. Verify that the tax amount is updated ==== case 2 ==== 18. Dismiss the RHN clicking outside 19. In the DM chat with yourself, click "+ > Track expense" and create an expense with a different currency 20. Wait for the concierge message with actions and click "Categorize it" 21. The RHN should open with the workspace as the only alternative, select the workspace 22. Choose any category from the list 23. In the expense form, click "Show more" 24. Verify that the tax code is set to the default tax code for expenses with a different currency of the workspace ==== case 3 ==== 25. Dismiss the RHN clicking outside 26. In the DM chat with yourself, click "+ > Track expense" and create a distance request 27. Wait for the concierge message with actions and click "Categorize it" 28. The RHN should open with the workspace as the only alternative, select the workspace 29. Choose any category from the list 30. Verify that the tax code is set to the default tax code for the distance rate selected