[HOLD for payment 2021-12-06] The Android hardware back button does not minimise the app when pressed on the LHN/home screen

[kp17211]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Click on an a chat from the LHN
2. Once you're in the chat, press the back button to navigate back to the LHN/home screen
3. From the LHN/home screen, press the back button again

Expected Result:

• When pressing the back button on the LHN/home screen, the app should be minimised (exited).

Actual Result:

• When pressing the back button on the LHN/home screen, we navigate back to the previous chat that users was in.

Workaround:

• None

Platform:

Where is this issue occurring?

• [ ] Web
• [ ] iOS
• [x] Android
• [ ] Desktop App
• [ ] Mobile Web

Version Number: Logs: https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation Upwork URL: https://www.upwork.com/jobs/~017e60e720f6f9aca8

View all open jobs on Upwork

[parasharrajat]

Ok, I think I start by creating a clone of the issue and then put a PR for the same and wait for things to move.

I think this would be enough for this issue as the Stack navigator will handle the rest.

[Beamanator]

@parasharrajat that sounds great, thanks! I assigned you this issue, I think we can move forward with this even though this is on hold since it's external to our repo

[parasharrajat]

No activity on the issue: https://github.com/react-navigation/react-navigation/issues/9936. Feature request: https://react-navigation.canny.io/feature-requests/p/allow-disabling-backhandler-subscription-in-drawerview

[parasharrajat]

Update: I don't think the maintainer will ever respond to https://github.com/react-navigation/react-navigation/issues/9936. It just seems like a waste of effort.

[Beamanator]

I think we're not in a huge rush with this one, so we could just bump it every so often (maybe taking turns posting in the issue) to see if we can grab attention

[Julesssss]

They accept sponsors, let's offer a few month's sponsorship (or one-off donation) in return for reviewing our request and PR?

[trjExpensify]

That's an awesome idea, Jules!

On Thu, Sep 30, 2021 at 3:05 PM Jules Rosser @.***> wrote:

They accept sponsors, let's offer a few month's sponsorship in return for reviewing our request and PR?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Expensify/App/issues/4211#issuecomment-931354718, or unsubscribe https://github.com/notifications/unsubscribe-auth/AD3246NBBT7CSIPDEFPQF5LUERVD7ANCNFSM5A5M5AVQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

--

Tom Rhys Jones Expensify

[Julesssss]

FYI, I'm removing the above comment for internal discussion. But I will report back and reach out tomorrow.

[Beamanator]

Thanks @Julesssss ! Agreed it's an awesome idea 👍

[parasharrajat]

Its a great Idea. I am sure they would be happy to discuss best possible solution at least.

[kadiealexander]

Please refer to this post for updated information on the n6 hold, we've raised the bonus to $250 for all issues where a PR is created before the N6 hold is lifted.

[parasharrajat]

@Beamanator Hurray, the issue is fixed upstream and now I can create a PR to configure the app correctly and it will also fix https://github.com/Expensify/App/issues/5027.

[Beamanator]

Rajat is testing a few changes before we move forward with testing & merging

[Beamanator]

Rajat is responding to a few requested changes, but getting close!

[botify]

The solution for this issue has been :rocket: deployed to production :rocket: in version 1.1.12-3 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

• https://github.com/Expensify/App/pull/5745

If no regressions arise, payment will be issued on 2021-11-09. :confetti_ball:

[Beamanator]

Hmm looks like this PR got reverted here: https://github.com/Expensify/App/pull/6161 - @parasharrajat is looking into how to fix the issues that came from this PR

[Beamanator]

not overdue, @parasharrajat is actively working on a fix in ^ PR

[Beamanator]

Not overdue - fix is in staging, waiting to get to production

[botify]

The solution for this issue has been :rocket: deployed to production :rocket: in version 1.1.16-10 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

• https://github.com/Expensify/App/pull/6295

If no regressions arise, payment will be issued on 2021-12-06. :confetti_ball:

[parasharrajat]

Ping for

@trjExpensify

Information for your reference.

https://github.com/Expensify/App/pull/5745#issuecomment-948027934 has the breakdown for payment. Please skip the milestone for 5027.

Apart from it, there were two PR created for this issue. the first one https://github.com/Expensify/App/pull/5745 went through N6-Hold and the second https://github.com/Expensify/App/pull/6295 through Company Offsite Hold.

[trjExpensify]

Woof, this was a long one ey! So I presume from @mallenexpensify comment, this is the correct Upwork job, right? https://www.upwork.com/jobs/~017e60e720f6f9aca8

It's closed though and I couldn't see your proposal nor being hired Rajat, so we'll need to sort that out once confirmed this didn't move elsewhere. Then maybe @Beamanator can help confirm the total payable for this job at this point, skipping #5027. Am I reading it correctly that it should be $1,500?

[parasharrajat]

@Beamanator Could you please help us out here?

[Beamanator]

I just looked through and I also believe payment should be $1,500. Breakdown:

• $1000 for fixing this issue (this price was set here)
• $250 for https://github.com/react-navigation/react-navigation/issues/9936 (We agreed here) that this is a separate job
• $250 because this PR was submitted before the n6-hold ended so should get the $250 bonus

@parasharrajat you thought your PR would also fix https://github.com/Expensify/App/issues/5971, but we ended up closing it b/c it couldn't be reproduced, so no reward there.

[parasharrajat]

there were two PR created for this issue. the first one #5745 went through N6-Hold and the second #6295 through Company Offsite Hold.

@Beamanator I am not sure about this but do you think the two bonuses apply here n6-hold and company offsite hold? Could you please confirm that as well? Thanks.

[Beamanator]

Hmm here's my thinking:

• 6295 was officially "ready for review" on November 17 (see this comment)

• We ended the Company Offsite Hold on the 16th (see this slack message)

So I don't think that PR is eligible for the Company Offsite Hold bonus, let me know if you disagree though (also @trjExpensify)

[parasharrajat]

Correct. I overlooked it. Thanks.

[Beamanator]

No prob at all

[trjExpensify]

Awesome. Offer sent 👍

[trjExpensify]

All sorted, closing.