search

Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.03k stars 2.54k forks source link

App crashes after pressing R in metro bundler on iOS simulator #42160

Closed adamgrzybowski closed 4 days ago

adamgrzybowski commented 2 weeks ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.4.73-4 Reproducible in staging?: no Reproducible in production?: no If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: @adamgrzybowski Slack conversation:

Action Performed:

This crash only affects developers

Expected Result:

App reloads

Actual Result:

App crashes

Workaround:

Don't reload the app 🤷

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/Expensify/App/assets/67908363/1a309f89-c244-4142-8155-a9d9cfc07c41

View all open jobs on GitHub

melvin-bot[bot] commented 2 weeks ago

Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

adamgrzybowski commented 2 weeks ago

@WoLewicki is going to fix that

joekaufmanexpensify commented 2 weeks ago

Discussing here. Please hold on starting this in the interim until we confirm from an internal engineer that we want to prioritize this.

joekaufmanexpensify commented 2 weeks ago

Is the next step here to raise a PR?

joekaufmanexpensify commented 2 weeks ago

@WoLewicki @adamgrzybowski mind confirming if there is an ETA for a PR here?

WoLewicki commented 2 weeks ago

I'll try to get it ready today 🚀

mananjadhav commented 2 weeks ago

@mountiny @joekaufmanexpensify Does this need C+ review?

WoLewicki commented 2 weeks ago

Here is the PR: https://github.com/Expensify/App/pull/42343. Here is also a PR to markdown repository: https://github.com/Expensify/react-native-live-markdown/pull/349.

joekaufmanexpensify commented 2 weeks ago

@mountiny @joekaufmanexpensify Does this need C+ review?

I am not sure. Going to defer to Vit on this. I would wait until he chimes in.

joekaufmanexpensify commented 1 week ago

PR is in review. @mountiny I assume this needs C+ review, but interested if you agree before Manan goes ahead?

mountiny commented 1 week ago

I am not sure if we need to merge the patch, but instead we can wait for the fix from the https://github.com/Expensify/react-native-live-markdown/pull/349 imho

mananjadhav commented 1 week ago

Agreed makes sense. I am assuming it's not blocking anyone. It'll only slow done the dev and we can get the PR merged asap.

joekaufmanexpensify commented 5 days ago

PR still in review

WoLewicki commented 4 days ago

I think we can close this one since the changes are already on main and working (see https://github.com/Expensify/App/pull/42343#issuecomment-2136586671)

mountiny commented 4 days ago

Ok perfect, thanks!