Closed pecanoro closed 2 weeks ago
@rushatgabhane Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]
Damn, I think it is still looking weird on mobile
styles.flexReset
works on mobile but not web and desktop and the opposite for styles.flexBasisAuto
Edit: flexReset does not work well either way
Mmmmm so not a complete fix here, eh?
It works on all platforms except the native apps, so I would say let's merge this, and then the original author can find a better solution. Or find a proposal from a contirbutor
I'm down with that, does it at least make things look slightly better on native apps? If it's works, maybe ❌ but if it's same or better, yalla :shipit:
### Fixed Issues
section aboveTests
sectionQA steps
sectiontoggleReport
and not onIconClick
).myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components using Avatar
have been tested & I retested again)/** comment above it */
this
properly so there are no scoping issues (i.e. for onClick={this.submit}
the method this.submit
should be bound to this
in the constructor)this
are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this);
if this.submit
is never passed to a component event handler like onClick
)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG
)Avatar
is modified, I verified that Avatar
is working as expected in all cases)Design
label and/or tagged @Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test
steps.It looks the same on native, not worst, but it doesn't look terrible either
🚀 Deployed to staging by https://github.com/Beamanator in version: 1.4.75-0 🚀
platform | result |
---|---|
🤖 android 🤖 | success ✅ |
🖥 desktop 🖥 | success ✅ |
🍎 iOS 🍎 | success ✅ |
🕸 web 🕸 | success ✅ |
🚀 Deployed to production by https://github.com/puneetlath in version: 1.4.75-1 🚀
platform | result |
---|---|
🤖 android 🤖 | success ✅ |
🖥 desktop 🖥 | success ✅ |
🍎 iOS 🍎 | success ✅ |
🕸 web 🕸 | success ✅ |
Details
Fixed Issues
$ https://github.com/Expensify/App/issues/42210 PROPOSAL:
Tests / QA steps
Go to any chat.
Go to + > Split expense.
Split a scan expense.
Click on the split preview.
There will be no excessive space in the split header and looks like:
Repeat the process with a manual split, it should look like:
Offline tests
Same as QA steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
![image](https://github.com/Expensify/App/assets/6474442/38ba91f9-3e41-48b0-b5b4-b2ae7fe7c3b3)Android: mWeb Chrome
![image](https://github.com/Expensify/App/assets/6474442/965dce8b-910d-4d9f-ad0c-008a150d55b1) ![image](https://github.com/Expensify/App/assets/6474442/d06cc6bb-bb5d-4784-b416-7913e36fdeaf)iOS: Native
![image](https://github.com/Expensify/App/assets/6474442/290e26ed-b1c9-42ce-9655-ebdb62f85337)iOS: mWeb Safari
![image](https://github.com/Expensify/App/assets/6474442/166a60c0-b52f-4b5c-bce3-643bf14c84fb) ![image](https://github.com/Expensify/App/assets/6474442/2f94ec12-3dad-47f2-94a9-b0f6eb4e1602)MacOS: Chrome / Safari
![image](https://github.com/Expensify/App/assets/6474442/efb84161-9929-4b2c-ae25-4ad10a97a8ee) ![image](https://github.com/Expensify/App/assets/6474442/192873b9-422a-49d2-9f95-d77fccb3251e)MacOS: Desktop
![image](https://github.com/Expensify/App/assets/6474442/0202e034-8e25-4673-a0f9-692d5979658d) ![image](https://github.com/Expensify/App/assets/6474442/af55fbcf-13bd-47ee-ac9b-9b1d810e6707)