Closed neil-marcellini closed 2 weeks ago
@rushatgabhane Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]
@neil-marcellini I saw a contributor put another PR, should we close this one?
Yeah we can close this since the other one went out already. I think the other solution is probably better. I didn't really have time to fully evaluate both, but I guess we'll know if something breaks on staging.
Details
cc @pecanoro @srikarparsi
Fixed Issues
$ https://github.com/Expensify/App/issues/42207 PROPOSAL: N/A
Tests
Offline tests
N/A
QA Steps
Same as tests
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
I only tested on Mac Chrome because it's only applicable for Web platforms with a mouse.
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
https://github.com/Expensify/App/assets/26260477/a3481604-f918-41c3-8984-d5c7214e129bMacOS: Desktop