Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.03k stars 2.54k forks source link

[NO QA] Fix values of EXPORTED_* actions #42242

Closed Beamanator closed 2 days ago

Beamanator commented 2 weeks ago

Details

During initial report action import (into App repo) looks like a few of these were messed up, understandably since the report action Variable name is not the same as the actual string name :D

Fixed Issues

$ See https://github.com/Expensify/App/pull/38013#discussion_r1602140032

Tests

No manual tests needed, just verify that these report action consts do actually match the values we have in the backend

Offline tests

N/A

QA Steps

N/A

PR Author Checklist

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop
melvin-bot[bot] commented 2 weeks ago

@ Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Beamanator commented 2 weeks ago

Fixed @arosiclair šŸ™

arosiclair commented 2 weeks ago

Reviewer Checklist

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop
arosiclair commented 2 weeks ago

Merge freeze just hit unfortunately

Beamanator commented 2 days ago

@arosiclair merge freeze is off!

arosiclair commented 2 days ago

You can self merge too lol. I'll merge now though

Beamanator commented 2 days ago

yeah, but free points? šŸ¤·

OSBotify commented 2 days ago

šŸš€ Deployed to staging by https://github.com/arosiclair in version: 1.4.77-11 šŸš€

platform result
šŸ¤– android šŸ¤– failure āŒ
šŸ–„ desktop šŸ–„ success āœ…
šŸŽ iOS šŸŽ success āœ…
šŸ•ø web šŸ•ø success āœ…
OSBotify commented 2 days ago

šŸš€ Deployed to staging by https://github.com/arosiclair in version: 1.4.77-11 šŸš€

platform result
šŸ¤– android šŸ¤– success āœ…
šŸ–„ desktop šŸ–„ success āœ…
šŸŽ iOS šŸŽ success āœ…
šŸ•ø web šŸ•ø success āœ