Closed Beamanator closed 2 days ago
@ Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]
Fixed @arosiclair š
### Fixed Issues
section aboveTests
sectionQA steps
sectiontoggleReport
and not onIconClick
).myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components using Avatar
have been tested & I retested again)/** comment above it */
this
properly so there are no scoping issues (i.e. for onClick={this.submit}
the method this.submit
should be bound to this
in the constructor)this
are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this);
if this.submit
is never passed to a component event handler like onClick
)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG
)Avatar
is modified, I verified that Avatar
is working as expected in all cases)Design
label and/or tagged @Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test
steps.Merge freeze just hit unfortunately
@arosiclair merge freeze is off!
You can self merge too lol. I'll merge now though
yeah, but free points? š¤·
š Deployed to staging by https://github.com/arosiclair in version: 1.4.77-11 š
platform | result |
---|---|
š¤ android š¤ | failure ā |
š„ desktop š„ | success ā |
š iOS š | success ā |
šø web šø | success ā |
š Deployed to staging by https://github.com/arosiclair in version: 1.4.77-11 š
platform | result |
---|---|
š¤ android š¤ | success ā |
š„ desktop š„ | success ā |
š iOS š | success ā |
šø web šø | success ā |
Details
During initial report action import (into App repo) looks like a few of these were messed up, understandably since the report action
Variable
name is not the same as the actual string name :DFixed Issues
$ See https://github.com/Expensify/App/pull/38013#discussion_r1602140032
Tests
No manual tests needed, just verify that these report action consts do actually match the values we have in the backend
Offline tests
N/A
QA Steps
N/A
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop