Closed blazejkustra closed 3 days ago
@hoangzinh Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]
I'm unsure if we need a C+ review on this one @hoangzinh, let's wait for internal approval
I assume no design review is needed here if there's no visual changes?
@dubielzyk-expensify That's right, no visual changes.
FYI TS is failing due to this
@blazejkustra do we need this to be merged before?
Because this is just removing prop type related codes, the only thing we should make sure is that there is no TS errors and app builds without an issue. No need for C+ review @hannojg π
I requested an ad hoc build. It might fail because of the TS error (which will be fixed in another PR)
:test_tube::test_tube: Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! :test_tube::test_tube: | Android :robot: | iOS :apple: |
---|---|---|
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/42249/index.html | https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/42249/index.html | |
Desktop :computer: | Web :spider_web: | |
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/42249/NewExpensify.dmg | https://42249.pr-testing.expensify.com | |
:eyes: View the workflow run that generated this build :eyes:
@blazejkustra do we need this to be merged before?
@hayata-suenaga Yes, because TS on main was failing, now should be good π
The PR looks good to me. Because we have a company wide merge freeze right now, I'll put a HOLD on this issue.
I updated the branch, so back to you @hayata-suenaga π
I'll put HOLD back to this issue as we're still gradually lifting Merge Freeze and this PR touches several files (although I know this is just removing unused pop types) π
Makes sense! Let's come back to this next week/later π
actually, the complete merge freeze lift was announced yesterday. We can merge this now π
### Fixed Issues
section aboveTests
sectionQA steps
sectiontoggleReport
and not onIconClick
).myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components using Avatar
have been tested & I retested again)/** comment above it */
this
properly so there are no scoping issues (i.e. for onClick={this.submit}
the method this.submit
should be bound to this
in the constructor)this
are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this);
if this.submit
is never passed to a component event handler like onClick
)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG
)Avatar
is modified, I verified that Avatar
is working as expected in all cases)Design
label so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test
steps.:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.
π Deployed to staging by https://github.com/hayata-suenaga in version: 1.4.77-11 π
platform | result |
---|---|
π€ android π€ | failure β |
π₯ desktop π₯ | success β |
π iOS π | success β |
πΈ web πΈ | success β |
π Deployed to staging by https://github.com/hayata-suenaga in version: 1.4.77-11 π
platform | result |
---|---|
π€ android π€ | success β |
π₯ desktop π₯ | success β |
π iOS π | success β |
πΈ web πΈ | success β |
Details
Remove all remaining prop-types from the project, and uninstall prop-types package!
Fixed Issues
$ https://github.com/Expensify/App/issues/31919 PROPOSAL: N/A
Tests
N/A
Offline tests
N/A
QA Steps
N/A
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop