search

Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.03k stars 2.54k forks source link

[HOLD for payment 2024-06-06] Split - Tab key highlights the next user instead of focusing the next split amount input #42258

Open izarutskaya opened 2 weeks ago

izarutskaya commented 2 weeks ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.4.74-1 Reproducible in staging?: Y Reproducible in production?: N Logs: https://stackoverflow.com/c/expensify/questions/4856 Issue reported by: Applause-Internal team

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to group chat.
  3. Go to + > Split expense > Manual.
  4. Enter amount > Next.
  5. On confirmation page, click on the split amount input.
  6. Use Tab key to switch to the next input.

Expected Result:

When the split amount input is in focus, one press on Tab key will switch to the next input (production behavior).

Actual Result:

When the split amount input is in focus, one press on Tab key highlights the next user. Only the second press switches to the next input.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

https://github.com/Expensify/App/assets/115492554/599dae1a-50ca-42a9-85c2-b61b62cb73e1

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @lschurr
melvin-bot[bot] commented 2 weeks ago

Triggered auto assignment to @lschurr (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

melvin-bot[bot] commented 2 weeks ago

Triggered auto assignment to @techievivek (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

github-actions[bot] commented 2 weeks ago

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.
melvin-bot[bot] commented 2 weeks ago

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open Staging deploy checklist to see the list of PRs included in this release, then work quickly on the following:

  1. If you find which PR caused the issue/bug, you can reassign it to the person responsible for it.
    • If the author is OOO or won’t get online before the daily deploy is due, you are responsible for finding the best fix/path forward. Don’t hesitate to ask for help!
  2. Try to reproduce the issue, if the bug is on production, remove the DeployBlocker label but stay assigned to fix it (or find out which PR broke it to get help from the author).
    • You can adjust the urgency of the issue to better represent the gravity of the bug.
    • If the issue is super low priority, feel free to un-assign yourself.
    • Be careful with PHP warnings, sometimes it is more complex than just adding a null coalescing operator as they might be uncovering some bigger bug.
    • If it was a one-off issue that requires no action (for example, Bedrock was down or it is a duplicated issue), you can close it.

Remember rule #2: Never un-assign yourself from a real DeployBlocker unless you are 100% sure someone else is assigned and will take care of it.

izarutskaya commented 2 weeks ago

@lschurr I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

izarutskaya commented 2 weeks ago

We think this issue might be related to the #vip-split.

izarutskaya commented 2 weeks ago

Production

https://github.com/Expensify/App/assets/115492554/94cec178-e245-4238-a1bf-3450997d2447

MonilBhavsar commented 2 weeks ago

Going through deploy checklist to find offending PR

MonilBhavsar commented 2 weeks ago

Looks this PR https://github.com/Expensify/App/pull/40785 Minor issue so removing deploy blocker label

MrMuzyk commented 2 weeks ago

I am Michał from Callstack - expert contributor group. I’d like to work on this job.

I'm also the author of the big PR that introduced this bug and have an idea on how to fix this - tabIndex is not being passed via props to children thus the focusing issue

MrMuzyk commented 2 weeks ago

PR is up (TS checks are failing due to unrelated errors in main). Ready to be reviewed. Hope it's ok that I've skipped proposal part - in the past it wasn't needed in a case when I was fixing regression from my previous PR

MrMuzyk commented 2 weeks ago

Rebased with latest main and all checks are green now

rushatgabhane commented 1 week ago

PR approved

MonilBhavsar commented 1 week ago

Thanks!

melvin-bot[bot] commented 2 days ago

Reviewing label has been removed, please complete the "BugZero Checklist".

melvin-bot[bot] commented 2 days ago

The solution for this issue has been :rocket: deployed to production :rocket: in version 1.4.77-11 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-06-06. :confetti_ball:

For reference, here are some details about the assignees on this issue:

melvin-bot[bot] commented 2 days ago

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed: