Open izarutskaya opened 2 weeks ago
Triggered auto assignment to @carlosmiceli (DeployBlockerCash
), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.
Triggered auto assignment to @zanyrenney (Bug
), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open Staging deploy checklist to see the list of PRs included in this release, then work quickly on the following:
Remember rule #2: Never un-assign yourself from a real DeployBlocker unless you are 100% sure someone else is assigned and will take care of it.
:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
@zanyrenney I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.
@Expensify/design this looks like a bug, yeah? I think we can call this NAB cuz it's not very noticeable, thoughts?
You can only access the search page right now via the troubleshooting menu (or knowing the URL directly) until we add the bottom tab for Search
to release it. So definitely not a deploy blocker. 👍 CC: @luacmartins
Two things for you to follow up on @luacmartins:
The line height of any font/text that is at a size of 13px should be using 16px. Right now it's 18px for some reason?
Then if we take the min-height off of the value, it should vertically center itself just fine.
So what we might want to consider is putting the min-height of 20px on the flex wrapper that wraps the value, and then make sure everything is vertically centered from there. Let me know if that makes sense!
Hey I will take care of this because I'm actively working on Search components and its cheaper to just add this small fix as part of another PR, than to create a whole new PR just for this.
thanks @shawnborton for pointing out the font sizes, I'll straighten this out.
Wonderful - thanks!
@shawnborton inside this PR I have updated text aligning: https://github.com/Expensify/App/pull/42248
You can check the screen or video, or run my branch if thats something you can do.
Not every font is the same size - for example names are smaller (I believe this is on purpose) but I expect things to look aligned/centered. Please tell me if this looks ok to you.
Sounds good, can you actually leave a similar comment on that PR too so we know to look for it during review? I'll spin up a test build on that PR as well. Thanks!
Just to confirm, the PR for Add sorting
will take care of this issue, right?
Yup!
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 1.4.74.1 Reproducible in staging?: Y Reproducible in production?: Unable to check Found when validating PR : https://github.com/Expensify/App/pull/41672 Logs: https://stackoverflow.com/c/expensify/questions/4856 Issue reported by: Applause-Internal team
Action Performed:
Precondition: Have at least one submitted expense.
Expected Result:
The whole row should be in line.
Actual Result:
Date and Mearchant value text isn't line with each other in the row.
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
View all open jobs on GitHub
Issue Owner
Current Issue Owner: @Kicu