Closed bernhardoj closed 5 days ago
@DylanDylann Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]
### Fixed Issues
section aboveTests
sectionQA steps
sectiontoggleReport
and not onIconClick
).myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components using Avatar
have been tested & I retested again)/** comment above it */
this
properly so there are no scoping issues (i.e. for onClick={this.submit}
the method this.submit
should be bound to this
in the constructor)this
are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this);
if this.submit
is never passed to a component event handler like onClick
)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG
)Avatar
is modified, I verified that Avatar
is working as expected in all cases)Design
label and/or tagged @Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test
steps.@bernhardoj Everything looks good. One minor thing, in the test step we should add the "Login" step as the first step
Updated
@bernhardoj Please resolve conflict
There is no conflict
π Deployed to staging by https://github.com/puneetlath in version: 1.4.76-0 π
platform | result |
---|---|
π€ android π€ | success β |
π₯ desktop π₯ | success β |
π iOS π | success β |
πΈ web πΈ | success β |
π Deployed to production by https://github.com/Beamanator in version: 1.4.76-7 π
platform | result |
---|---|
π€ android π€ | success β |
π₯ desktop π₯ | success β |
π iOS π | success β |
πΈ web πΈ | success β |
Details
The delay is caused by the withOnyx returning null when the data are not ready yet. This PR migrates it to useOnyx hook.
Fixed Issues
$ https://github.com/Expensify/App/issues/41523 PROPOSAL: https://github.com/Expensify/App/issues/41523#issuecomment-2092814191
Tests
Same as QA Steps
Offline tests
Same as QA Steps
QA Steps
Prerequisite: have submitted more than 1 expense to anyone
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
https://github.com/Expensify/App/assets/50919443/aa956105-d030-4f47-8f23-dc682d25df6fAndroid: mWeb Chrome
https://github.com/Expensify/App/assets/50919443/9f1a1e73-e778-4bc7-b8d7-ec87d443c92biOS: Native
https://github.com/Expensify/App/assets/50919443/3df2d14e-274b-496c-af82-5add8e4bc7b9iOS: mWeb Safari
https://github.com/Expensify/App/assets/50919443/1859f910-af66-41f7-b87d-b985f582da29MacOS: Chrome / Safari
https://github.com/Expensify/App/assets/50919443/6f98afb6-a207-4cff-8d94-040c12cf5f24MacOS: Desktop
https://github.com/Expensify/App/assets/50919443/2289b8c1-2989-45f0-a7d7-9cf8e91e4eca