Closed WojtekBoman closed 5 days ago
@ahmedGaber93 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]
### Fixed Issues
section aboveTests
sectionQA steps
sectiontoggleReport
and not onIconClick
).myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components using Avatar
have been tested & I retested again)/** comment above it */
this
properly so there are no scoping issues (i.e. for onClick={this.submit}
the method this.submit
should be bound to this
in the constructor)this
are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this);
if this.submit
is never passed to a component event handler like onClick
)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG
)Avatar
is modified, I verified that Avatar
is working as expected in all cases)Design
label and/or tagged @Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test
steps.Fixed issues:
[x] cleanup const
we still need to fix deeplink issue https://github.com/Expensify/App/pull/41769#issuecomment-2103446491 that mentioned here https://github.com/Expensify/App/pull/41769#pullrequestreview-2050573677
I faced this issue while recording videos. But because it already reproduced in latest main. I continue testing the PR issues and ignore it.
https://github.com/Expensify/App/assets/41129870/1c2ea0a1-95fe-47ea-bbb6-409bc3d267f2
@WojtekBoman we still need to fix deeplink issue https://github.com/Expensify/App/pull/41769#issuecomment-2103446491 that mentioned here https://github.com/Expensify/App/pull/41769#pullrequestreview-2050573677
@WojtekBoman deeplinks now works good 👍. But I found this issue after open search page from deeplink.
Bug: workspace-switcher not highlight the active workspace after open search page from deeplink
npx uri-scheme open 'new-expensify://search/all?policyIDs=YOUR_WORKSPACE_ID' --android
Workspace-switcher not highlight the active workspace, and instead it highlights the Expensify choice.
https://github.com/Expensify/App/assets/41129870/e3e1ba3f-7f74-42ca-9369-19af65059906
@adamgrzybowski I am not sure if remove forced up is related to this PR or not. Can you help me to test it by adding some test steps for it if it is a global refactor?
@ahmedGaber93 As you may see there are some changes in the linkTo file. I used this opportunity to clean this function a little and split it into files.
While working on it, I noticed that the FORCE_UP
and UP
do exactly the same thing. At some point when we were working on the navigation architecture, the difference between the two functions disappeared. I decided to remove one of these functions to avoid confusion in the future. It shouldn't affect behavior in any way.
@ahmedGaber93
Bug: workspace-switcher not highlight the active workspace after open search page from deeplink
I have pushed a commit that should fix this bug, please verify.
@Kicu still not fixed with me.
npx uri-scheme open 'new-expensify://search/all?policyIDs=YOUR_WORKSPACE_ID' --android
.Workspace-switcher not highlight the active workspace, and instead it highlights the Expensify choice.
https://github.com/Expensify/App/assets/41129870/45b3af93-21de-4a21-9a4c-ed4f0879644b
@ahmedGaber93 Should work now! We missed one place in linkTo
@adamgrzybowski Thanks for your patience. It works fine now 👍, but I faced a new issue when click the hardware back on android, it displays not found screen.
https://github.com/Expensify/App/assets/41129870/a6ccba27-7560-4cc3-ba49-42b85f985789
@ahmedGaber93 Thanks for finding all these stuff that we missed!
I am investigating the problem you reported 🕵️♂️ I think I should have a fix today.
@ahmedGaber93 I think I found the root cause, but I need to confirm with my team why we made some changes. Let me come back to this on Monday
@ahmedGaber93 should work now 🤞
:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.
🚀 Deployed to staging by https://github.com/luacmartins in version: 1.4.77-0 🚀
platform | result |
---|---|
🤖 android 🤖 | success ✅ |
🖥 desktop 🖥 | success ✅ |
🍎 iOS 🍎 | success ✅ |
🕸 web 🕸 | success ✅ |
🚀 Deployed to production by https://github.com/puneetlath in version: 1.4.77-11 🚀
platform | result |
---|---|
🤖 android 🤖 | failure ❌ |
🖥 desktop 🖥 | success ✅ |
🍎 iOS 🍎 | success ✅ |
🕸 web 🕸 | success ✅ |
🚀 Deployed to production by https://github.com/puneetlath in version: 1.4.77-11 🚀
platform | result |
---|---|
🤖 android 🤖 | success ✅ |
🖥 desktop 🖥 | success ✅ |
🍎 iOS 🍎 | success ✅ |
🕸 web 🕸 | success ✅ |
Details
This PR fixes calling
/Search
multiple times. Now all parameters sent in the/Search
request are stored inroute.params
, this prevents theSearch
component from being re-rendered. This PR includes also a fix foruseActiveWorkspaceFromNavigationState
hook, the additional check has been added to returnundefined
instead of the empty string, it fixes the issue with displaying the placeholder in the Workspace Switcher instead of the Expensify logo.https://github.com/Expensify/App/assets/47774969/048c3974-b01a-45bb-a477-9a880079fac1
Fixed Issues
$ https://github.com/Expensify/App/issues/42177 PROPOSAL:
Tests
/Search
request is sent only once when thepolicyIDs
param is modifiedOffline tests
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
https://github.com/Expensify/App/assets/47774969/e06fb6b9-db8f-4b82-bac7-13441985fcbcMacOS: Desktop
https://github.com/Expensify/App/assets/47774969/5c6f96c6-978b-4736-b5e0-40437e12d80b