Closed nkdengineer closed 4 days ago
@akinwale Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]
@nkdengineer Please update the third test step to give an idea of what an optimistic update means (e.g. verify that the amount is updated immediately)
### Fixed Issues
section aboveTests
sectionQA steps
sectiontoggleReport
and not onIconClick
).myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components using Avatar
have been tested & I retested again)/** comment above it */
this
properly so there are no scoping issues (i.e. for onClick={this.submit}
the method this.submit
should be bound to this
in the constructor)this
are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this);
if this.submit
is never passed to a component event handler like onClick
)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG
)Avatar
is modified, I verified that Avatar
is working as expected in all cases)Design
label and/or tagged @Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test
steps.@akinwale I updated the test step.
@neil-marcellini I updated your suggestions. Please help to check again. Thanks.
:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.
🚀 Deployed to staging by https://github.com/neil-marcellini in version: 1.4.77-0 🚀
platform | result |
---|---|
🤖 android 🤖 | success ✅ |
🖥 desktop 🖥 | success ✅ |
🍎 iOS 🍎 | success ✅ |
🕸 web 🕸 | success ✅ |
🚀 Deployed to production by https://github.com/puneetlath in version: 1.4.77-11 🚀
platform | result |
---|---|
🤖 android 🤖 | failure ❌ |
🖥 desktop 🖥 | success ✅ |
🍎 iOS 🍎 | success ✅ |
🕸 web 🕸 | success ✅ |
🚀 Deployed to production by https://github.com/puneetlath in version: 1.4.77-11 🚀
platform | result |
---|---|
🤖 android 🤖 | success ✅ |
🖥 desktop 🖥 | success ✅ |
🍎 iOS 🍎 | success ✅ |
🕸 web 🕸 | success ✅ |
Details
Fix amount of distance request isn't updated optimistically
Fixed Issues
$ https://github.com/Expensify/App/issues/41817 PROPOSAL: https://github.com/Expensify/App/issues/41817#issuecomment-2099770283
Tests
Offline tests
None
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
https://github.com/Expensify/App/assets/161821005/e86fda57-03c3-41a3-b67e-34ff104c54caAndroid: mWeb Chrome
https://github.com/Expensify/App/assets/161821005/6c249527-8530-441f-8225-2c465915036eiOS: Native
https://github.com/Expensify/App/assets/161821005/2a88c734-cafb-4d41-ba7b-03c5c2e2f841iOS: mWeb Safari
https://github.com/Expensify/App/assets/161821005/50e3a362-8fc2-4c41-8807-51d9d9174ac8MacOS: Chrome / Safari
https://github.com/Expensify/App/assets/161821005/cbb5f2fe-a1dd-46fd-9e28-68ff68daccf6MacOS: Desktop
https://github.com/Expensify/App/assets/161821005/6810ff82-6af4-4641-8762-300744df4245