Open nkdengineer opened 2 weeks ago
@allroundexperts Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]
### Fixed Issues
section aboveTests
sectionQA steps
sectiontoggleReport
and not onIconClick
).myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components using Avatar
have been tested & I retested again)/** comment above it */
this
properly so there are no scoping issues (i.e. for onClick={this.submit}
the method this.submit
should be bound to this
in the constructor)this
are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this);
if this.submit
is never passed to a component event handler like onClick
)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG
)Avatar
is modified, I verified that Avatar
is working as expected in all cases)Design
label and/or tagged @Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test
steps.@tgolen Can we merge this now?
@tgolen Please help to review the PR again when you have a chance. Thanks.
Details
Fixed Issues
$ https://github.com/Expensify/App/issues/42083 PROPOSAL: https://github.com/Expensify/App/issues/42083#issuecomment-2108344637
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
https://github.com/Expensify/App/assets/161821005/fa47085b-3823-4c08-a726-7b1d1ef6b9cbAndroid: mWeb Chrome
https://github.com/Expensify/App/assets/161821005/ddcd8baa-fdff-4c42-969e-27b6f69ab1a0iOS: Native
https://github.com/Expensify/App/assets/161821005/4b13a5ae-d17d-43e3-9514-2c58b94f0080iOS: mWeb Safari
https://github.com/Expensify/App/assets/161821005/572b1cdf-b1c0-4015-8458-bb5664e39252MacOS: Chrome / Safari
https://github.com/Expensify/App/assets/161821005/570ab4f0-6b3e-4254-a51b-e7f1e5a347bcMacOS: Desktop
https://github.com/Expensify/App/assets/161821005/7c54224f-d07a-48cf-a52b-bf8f02c2c3c0