Add tax fields for distance requests

[narefyev91]

Details

This PR adds Support for tax tracking when offline. (continue work from https://github.com/Expensify/App/pull/41379)

Fixed Issues

$ https://github.com/Expensify/App/issues/31673 PROPOSAL:

Tests

• Submit Expense for Distance request
  1. Go to workspace chat.
  2. Start a Submit expense (money request) flow.
  3. Select the distance tab
  4. enter the start and stop locations then select next
  5. Submit Expense

Expectation: Both the tax amount and tax rate fields cannot be modified - no right icon and the tax row is not interactive. Edit Expense for Distance request Go to the transaction thread and previously submitted distance expense. Expectation: Both the tax amount and tax rate fields cannot be modified - no right icon and the tax row is not interactive.

1. Create some distance rates and taxes inside your workspace
2. Start a Submit expense (money request) flow - manual one
3. Switch tax - and verify that tax amount will be changed
4. Move to Distance tab
5. Change distance rate - and verify that tax amount is also changed

• [x] Verify that no errors appear in the JS console

Offline tests

• Submit Expense for Distance request
  1. Go to workspace chat.
  2. Start a Submit expense (money request) flow.
  3. Select the distance tab
  4. enter the start and stop locations then select next
  5. Submit Expense

Expectation: Both the tax amount and tax rate fields cannot be modified - no right icon and the tax row is not interactive. Edit Expense for Distance request Go to the transaction thread and previously submitted distance expense. Expectation: Both the tax amount and tax rate fields cannot be modified - no right icon and the tax row is not interactive.

1. Create some distance rates and taxes inside your workspace
2. Start a Submit expense (money request) flow - manual one
3. Switch tax - and verify that tax amount will be changed
4. Move to Distance tab
5. Change distance rate - and verify that tax amount is also changed

QA Steps

• Submit Expense for Distance request
  1. Go to workspace chat.
  2. Start a Submit expense (money request) flow.
  3. Select the distance tab
  4. enter the start and stop locations then select next
  5. Submit Expense

Expectation: Both the tax amount and tax rate fields cannot be modified - no right icon and the tax row is not interactive. Edit Expense for Distance request Go to the transaction thread and previously submitted distance expense. Expectation: Both the tax amount and tax rate fields cannot be modified - no right icon and the tax row is not interactive.

1. Create some distance rates and taxes inside your workspace
2. Start a Submit expense (money request) flow - manual one
3. Switch tax - and verify that tax amount will be changed
4. Move to Distance tab
5. Change distance rate - and verify that tax amount is also changed

• [x] Verify that no errors appear in the JS console

PR Author Checklist

• [x] I linked the correct issue in the ### Fixed Issues section above
• [x] I wrote clear testing steps that cover the changes made in this PR
  • [x] I added steps for local testing in the Tests section
  • [x] I added steps for the expected offline behavior in the Offline steps section
  • [x] I added steps for Staging and/or Production testing in the QA steps section
  • [x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • [x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • [x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• [x] I included screenshots or videos for tests on all platforms
• [x] I ran the tests on all platforms & verified they passed on:
  • [x] Android: Native
  • [x] Android: mWeb Chrome
  • [x] iOS: Native
  • [x] iOS: mWeb Safari
  • [x] MacOS: Chrome / Safari
  • [x] MacOS: Desktop
• [x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• [x] I followed proper code patterns (see Reviewing the code)
  • [x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • [x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
  • [x] I verified that comments were added to code that is not self explanatory
  • [x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • [x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • [x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • [x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • [x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • [x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • [x] I verified the JSDocs style guidelines (in STYLE.md) were followed
• [x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• [x] I followed the guidelines as stated in the Review Guidelines
• [x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• [x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• [x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
• [x] I verified that if a function's arguments changed that all usages have also been updated correctly
• [x] If any new file was added I verified that:
  • [x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• [x] If a new CSS style is added I verified that:
  • [x] A similar style doesn't already exist
  • [x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• [x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• [x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• [x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• [x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• [x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • [x] I verified that all the inputs inside a form are aligned with each other.
  • [x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• [x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• [x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

https://github.com/Expensify/App/assets/28352309/f1f98fbf-51d2-471a-919b-8975a97eb1f4

Android: mWeb Chrome

https://github.com/Expensify/App/assets/28352309/cc07f485-f52b-48f9-8ed3-2eda4c540227

iOS: Native

https://github.com/Expensify/App/assets/28352309/06ee3c5e-48c2-4b91-b657-ffc731e5b355

iOS: mWeb Safari

https://github.com/Expensify/App/assets/28352309/30d941ab-7b5b-4fbe-8219-40940538bf66

MacOS: Chrome / Safari

https://github.com/Expensify/App/assets/28352309/eba3f22f-ecce-425d-8eb7-d0f7b7bccbae

MacOS: Desktop

https://github.com/Expensify/App/assets/28352309/e7b1337c-8bd4-4faa-aac9-2d24de6ae201

[melvin-bot[bot]]

@ishpaul777 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[narefyev91]

@MonilBhavsar could not make Eto's PR ready to review. Probably we can move here. Now we support fields visibility based on defined conditions, also new calculation from FE applied if user goes offline and distance rate is changed. I think we can start reviewing code and check if everything is good. I will prepare test cases and update videos in parallel.

[MonilBhavsar]

Thanks @narefyev91! In QA and Tests, can we include the step to update the distance rate and ensure tax amount is updated accordingly?

[ishpaul777]

Reviewer Checklist

• [x] I have verified the author checklist is complete (all boxes are checked off).
• [x] I verified the correct issue is linked in the ### Fixed Issues section above
• [x] I verified testing steps are clear and they cover the changes made in this PR
  • [x] I verified the steps for local testing are in the Tests section
  • [x] I verified the steps for Staging and/or Production testing are in the QA steps section
  • [x] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • [x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
• [x] I checked that screenshots or videos are included for tests on all platforms
• [x] I included screenshots or videos for tests on all platforms
• [x] I verified tests pass on all platforms & I tested again on:
  • [x] Android: Native
  • [x] Android: mWeb Chrome
  • [x] iOS: Native
  • [x] iOS: mWeb Safari
  • [x] MacOS: Chrome / Safari
  • [x] MacOS: Desktop
• [x] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
• [x] I verified proper code patterns were followed (see Reviewing the code)
  • [x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
  • [x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
  • [x] I verified that comments were added to code that is not self explanatory
  • [x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • [x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  • [x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • [x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • [x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • [x] I verified the JSDocs style guidelines (in STYLE.md) were followed
• [x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• [x] I verified that this PR follows the guidelines as stated in the Review Guidelines
• [x] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
• [x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• [x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
• [x] If a new component is created I verified that:
  • [x] A similar component doesn't exist in the codebase
  • [x] All props are defined accurately and each prop has a /** comment above it */
  • [x] The file is named correctly
  • [x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
  • [x] The only data being stored in the state is data necessary for rendering and nothing else
  • [x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
  • [x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
  • [x] All JSX used for rendering exists in the render method
  • [x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
• [x] If any new file was added I verified that:
  • [x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• [x] If a new CSS style is added I verified that:
  • [x] A similar style doesn't already exist
  • [x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
• [x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• [x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• [x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• [x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• [x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • [x] I verified that all the inputs inside a form are aligned with each other.
  • [x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• [x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• [x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
• [x] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

https://github.com/Expensify/App/assets/104348397/48a147b4-2c64-42f5-9bb8-c96c79af695d

Android: mWeb Chrome

https://github.com/Expensify/App/assets/104348397/beeab463-49a0-4ffd-9ef7-9d3059057be4

iOS: Native

https://github.com/Expensify/App/assets/104348397/ce1b1906-c73a-409b-924c-c655029c74c0

iOS: mWeb Safari

https://github.com/Expensify/App/assets/104348397/840a8d42-1926-45c2-a93d-c03f14c664de

MacOS: Chrome / Safari

https://github.com/Expensify/App/assets/104348397/cbedc118-c8d4-4a75-ac1d-42009cf22531

MacOS: Desktop

https://github.com/Expensify/App/assets/104348397/7f15131d-08f0-4dcb-9022-19a4c86e7da5

[ishpaul777]

On my list for today 😄

[ishpaul777]

currently i am enabling policy.customUnits.attributes.taxEnabled by executing Onyx in console is there a better way to enable it currently in App ?

[MonilBhavsar]

You can do it from oldDot app. Go to Workspaces > Select a workspace > Expenses > Distance

[ishpaul777]

Got it! Thanks @MonilBhavsar

[MonilBhavsar]

Thanks for the updates! Some more comments. Let's update this too and re test 🚀

[narefyev91]

Thanks for the updates! Some more comments. Let's update this too and re test 🚀

done!

[ishpaul777]

It works great, i just noticed one thing that feels confusing UX, If tax is 0% we still show the edit amount and we really can't change it throws error

https://github.com/Expensify/App/assets/104348397/3a8c0b8b-e570-4b94-9773-9059d1cb4770

[MonilBhavsar]

That's a feature 😄 As far as we're displaying error, it's fine UX, I think

[MonilBhavsar]

Not merging because of freeze

[trjExpensify]

@MonilBhavsar what about spinning up a feature branch for these remaining XeroCon commit /app issues? Then we can merge into that once review and approved, to keep other issues moving and testing the changes in aggregate. We're doing that for the Xero integration and it's working great!

[MonilBhavsar]

Sounds good! I'll do that. I was thinking to merge this next week after things stabilizes little.

[OSBotify]

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[OSBotify]

🚀 Deployed to staging by https://github.com/MonilBhavsar in version: 1.4.77-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

[OSBotify]

🚀 Deployed to production by https://github.com/puneetlath in version: 1.4.77-11 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

[OSBotify]

🚀 Deployed to production by https://github.com/puneetlath in version: 1.4.77-11 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅