Closed srikarparsi closed 4 days ago
@jjcoffee Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]
@jjcoffee, un-assigning because this is a pretty straightforward PR and I was talking to @Gonals about it earlier.
### Fixed Issues
section aboveTests
sectionQA steps
sectiontoggleReport
and not onIconClick
).myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components using Avatar
have been tested & I retested again)/** comment above it */
this
properly so there are no scoping issues (i.e. for onClick={this.submit}
the method this.submit
should be bound to this
in the constructor)this
are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this);
if this.submit
is never passed to a component event handler like onClick
)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG
)Avatar
is modified, I verified that Avatar
is working as expected in all cases)Design
label and/or tagged @Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test
steps.Approved! Feel free to ask for merge in #deployer!
Merging since merge slush got lifted :)
:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.
🚀 Deployed to staging by https://github.com/srikarparsi in version: 1.4.77-0 🚀
platform | result |
---|---|
🤖 android 🤖 | success ✅ |
🖥 desktop 🖥 | success ✅ |
🍎 iOS 🍎 | success ✅ |
🕸 web 🕸 | success ✅ |
🚀 Deployed to production by https://github.com/puneetlath in version: 1.4.77-11 🚀
platform | result |
---|---|
🤖 android 🤖 | failure ❌ |
🖥 desktop 🖥 | success ✅ |
🍎 iOS 🍎 | success ✅ |
🕸 web 🕸 | success ✅ |
🚀 Deployed to production by https://github.com/puneetlath in version: 1.4.77-11 🚀
platform | result |
---|---|
🤖 android 🤖 | success ✅ |
🖥 desktop 🖥 | success ✅ |
🍎 iOS 🍎 | success ✅ |
🕸 web 🕸 | success ✅ |
Details
More context in this issue but since we're migrating over the archived functionality to an rNVP instead of the state, we had to change the isArchivedRoom function to check for the rNVP instead of the state. Some checks still rely on the state so in this PR, I created the isClosedRoom function. I originally thought some more checks needed it but after talking to @Gonals, it looks like they don't. There's a couple of other places we might want to use this functionality but I'll handle those in a separate PR while working on these Auth changes.
Fixed Issues
$ https://github.com/Expensify/Expensify/issues/395780 PROPOSAL:
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Added small screen in mWeb ChromeAndroid: mWeb Chrome
iOS: Native
Added small screen in mWeb ChromeiOS: mWeb Safari
Added small screen in mWeb ChromeMacOS: Chrome / Safari
MacOS: Desktop
Added regular screen in MacOS: Chrome / Safari