search

Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.33k stars 2.76k forks source link

[Snyk] Fix for 1 vulnerabilities #42353

Closed melvin-bot[bot] closed 2 months ago

melvin-bot[bot] commented 3 months ago

This PR was automatically created by Snyk using the credentials of a real user.


Snyk has created this PR to fix one or more vulnerable packages in the `rubygems` dependencies of this project.

#### Changes included in this PR - Changes to the following files to upgrade the vulnerable dependencies to a fixed version: - Gemfile
⚠️ Warning ``` Failed to update the Gemfile.lock, please update manually before merging. ```
#### Vulnerabilities that will be fixed ##### With an upgrade: Severity | Priority Score (\*) | Issue | Breaking Change | Exploit Maturity :-------------------------:|-------------------------|:-------------------------|:-------------------------|:------------------------- ![medium severity](https://res.cloudinary.com/snyk/image/upload/w_20,h_20/v1561977819/icon/m.png 'medium severity') | **551/1000**
**Why?** Recently disclosed, Has a fix available, CVSS 5.3 | Uncontrolled Resource Consumption
[SNYK-RUBY-REXML-6861566](https://snyk.io/vuln/SNYK-RUBY-REXML-6861566) | No | No Known Exploit (\*) Note that the real score may have changed since the PR was raised. Check the changes in this PR to ensure they won't cause issues with your project. --- **Note:** _You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs._ For more information: 🧐 [View latest project report](https://app.snyk.io/org/expensify/project/f67ecd22-0c71-4fcb-a848-df7a67bf7330?utm_source=github&utm_medium=referral&page=fix-pr) 🛠 [Adjust project settings](https://app.snyk.io/org/expensify/project/f67ecd22-0c71-4fcb-a848-df7a67bf7330?utm_source=github&utm_medium=referral&page=fix-pr/settings) 📚 [Read more about Snyk's upgrade and patch logic](https://support.snyk.io/hc/en-us/articles/360003891078-Snyk-patches-to-fix-vulnerabilities) [//]: # 'snyk:metadata:{"customTemplate":{"variablesUsed":[],"fieldsUsed":[]},"dependencies":[{"name":"cocoapods","from":"1.13.0","to":"1.14.0"},{"name":"fastlane","from":"2.219.0","to":"2.220.0"}],"env":"prod","issuesToFix":[{"exploit_maturity":"No Known Exploit","id":"SNYK-RUBY-REXML-6861566","priority_score":551,"priority_score_factors":[{"type":"freshness","label":true,"score":71},{"type":"fixability","label":true,"score":214},{"type":"cvssScore","label":"5.3","score":265},{"type":"scoreVersion","label":"v1","score":1}],"severity":"medium","title":"Uncontrolled Resource Consumption"},{"exploit_maturity":"No Known Exploit","id":"SNYK-RUBY-REXML-6861566","priority_score":551,"priority_score_factors":[{"type":"freshness","label":true,"score":71},{"type":"fixability","label":true,"score":214},{"type":"cvssScore","label":"5.3","score":265},{"type":"scoreVersion","label":"v1","score":1}],"severity":"medium","title":"Uncontrolled Resource Consumption"},{"exploit_maturity":"No Known Exploit","id":"SNYK-RUBY-REXML-6861566","priority_score":551,"priority_score_factors":[{"type":"freshness","label":true,"score":71},{"type":"fixability","label":true,"score":214},{"type":"cvssScore","label":"5.3","score":265},{"type":"scoreVersion","label":"v1","score":1}],"severity":"medium","title":"Uncontrolled Resource Consumption"},{"exploit_maturity":"No Known Exploit","id":"SNYK-RUBY-REXML-6861566","priority_score":551,"priority_score_factors":[{"type":"freshness","label":true,"score":71},{"type":"fixability","label":true,"score":214},{"type":"cvssScore","label":"5.3","score":265},{"type":"scoreVersion","label":"v1","score":1}],"severity":"medium","title":"Uncontrolled Resource Consumption"},{"exploit_maturity":"No Known Exploit","id":"SNYK-RUBY-REXML-6861566","priority_score":551,"priority_score_factors":[{"type":"freshness","label":true,"score":71},{"type":"fixability","label":true,"score":214},{"type":"cvssScore","label":"5.3","score":265},{"type":"scoreVersion","label":"v1","score":1}],"severity":"medium","title":"Uncontrolled Resource Consumption"},{"exploit_maturity":"No Known Exploit","id":"SNYK-RUBY-REXML-6861566","priority_score":551,"priority_score_factors":[{"type":"freshness","label":true,"score":71},{"type":"fixability","label":true,"score":214},{"type":"cvssScore","label":"5.3","score":265},{"type":"scoreVersion","label":"v1","score":1}],"severity":"medium","title":"Uncontrolled Resource Consumption"},{"exploit_maturity":"No Known Exploit","id":"SNYK-RUBY-REXML-6861566","priority_score":551,"priority_score_factors":[{"type":"freshness","label":true,"score":71},{"type":"fixability","label":true,"score":214},{"type":"cvssScore","label":"5.3","score":265},{"type":"scoreVersion","label":"v1","score":1}],"severity":"medium","title":"Uncontrolled Resource Consumption"},{"exploit_maturity":"No Known Exploit","id":"SNYK-RUBY-REXML-6861566","priority_score":551,"priority_score_factors":[{"type":"freshness","label":true,"score":71},{"type":"fixability","label":true,"score":214},{"type":"cvssScore","label":"5.3","score":265},{"type":"scoreVersion","label":"v1","score":1}],"severity":"medium","title":"Uncontrolled Resource Consumption"},{"exploit_maturity":"No Known Exploit","id":"SNYK-RUBY-REXML-6861566","priority_score":551,"priority_score_factors":[{"type":"freshness","label":true,"score":71},{"type":"fixability","label":true,"score":214},{"type":"cvssScore","label":"5.3","score":265},{"type":"scoreVersion","label":"v1","score":1}],"severity":"medium","title":"Uncontrolled Resource Consumption"},{"exploit_maturity":"No Known Exploit","id":"SNYK-RUBY-REXML-6861566","priority_score":551,"priority_score_factors":[{"type":"freshness","label":true,"score":71},{"type":"fixability","label":true,"score":214},{"type":"cvssScore","label":"5.3","score":265},{"type":"scoreVersion","label":"v1","score":1}],"severity":"medium","title":"Uncontrolled Resource Consumption"}],"prId":"d66fde5b-6441-4f91-8b32-aa3a805e0754","prPublicId":"d66fde5b-6441-4f91-8b32-aa3a805e0754","packageManager":"rubygems","priorityScoreList":[551],"projectPublicId":"f67ecd22-0c71-4fcb-a848-df7a67bf7330","projectUrl":"https://app.snyk.io/org/expensify/project/f67ecd22-0c71-4fcb-a848-df7a67bf7330?utm_source=github&utm_medium=referral&page=fix-pr","prType":"fix","templateFieldSources":{"branchName":"default","commitMessage":"default","description":"default","title":"default"},"templateVariants":["pr-warning-shown","priorityScore"],"type":"auto","upgrade":["SNYK-RUBY-REXML-6861566"],"vulns":["SNYK-RUBY-REXML-6861566"],"patch":[],"isBreakingChange":false,"remediationStrategy":"vuln"}' --- **Note:** _This is a default PR template raised by Snyk. Find out more about how you can customise Snyk PRs in our [documentation.](https://docs.snyk.io/scan-using-snyk/snyk-open-source/automatic-and-manual-prs-with-snyk-open-source/customize-pr-templates-closed-beta)_ **Learn how to fix vulnerabilities with free interactive lessons:** 🦉 [Uncontrolled Resource Consumption](https://learn.snyk.io/lesson/redos/?loc=fix-pr)
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01b0e67567e18d03e7
  • Upwork Job ID: 1791540288063905792
  • Last Price Increase: 2024-05-17
melvin-bot[bot] commented 3 months ago

This is a Snyk issue. Snyk is a tool that automatically tracks our repositories' dependencies and reports associated security vulnerabilities. It also automatically create PRs to fix these vulnerabilities.

    C+: Please follow these steps to test the linked PR before running through the reviewer checklist:
    - [ ] The first step is to understand the PR: what dependency is it upgrading, for which vulnerability, how it impacts our product & end users.
    - [ ] If the issue is not worth fixing, please add your reasoning in the issue and have the internal engineer review it.
    - [ ] Check the change log (which should be included in the PR description) to see all changes. We want to identify any breaking changes. If it is a minor version bump, it's unlikely that there are any breaking changes.
    - [ ] Test our feature(s) that make use of this package. If it does not work, we should understand what broke it. It is also a good idea to check our main flows to make sure they are not broken that you can add in the checklist screenshots/videos.
melvin-bot[bot] commented 3 months ago

Job added to Upwork: https://www.upwork.com/jobs/~01b0e67567e18d03e7

melvin-bot[bot] commented 3 months ago

Triggered auto assignment to Contributor Plus for review of internal employee PR - @jayeshmangwani (Internal)

melvin-bot[bot] commented 3 months ago

This issue has not been updated in over 15 days. @jayeshmangwani eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

jayeshmangwani commented 2 months ago

We can close this issue. The Gemfile changes have been made in this PR #42352.

cc: @cristipaval

jayeshmangwani commented 2 months ago

Gemfile changes have been made in this PR https://github.com/Expensify/App/pull/42352. We can close this issue. I am approving this to assign someone to close the issue.

🎀 👀 🎀

melvin-bot[bot] commented 2 months ago

Triggered auto assignment to @hayata-suenaga, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

hayata-suenaga commented 2 months ago

According to this comment, I'm closing this issue.