Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.11k stars 2.61k forks source link

[Snyk] Security upgrade expo from 50.0.4 to 51.0.8 #42358

Open melvin-bot[bot] opened 1 month ago

melvin-bot[bot] commented 1 month ago

This PR was automatically created by Snyk using the credentials of a real user.


Snyk has created this PR to fix one or more vulnerable packages in the `npm` dependencies of this project.

#### Changes included in this PR - Changes to the following files to upgrade the vulnerable dependencies to a fixed version: - package.json
⚠️ Warning ``` Failed to update the package-lock.json, please update manually before merging. ```
#### Vulnerabilities that will be fixed ##### With an upgrade: Severity | Priority Score (\*) | Issue | Breaking Change | Exploit Maturity :-------------------------:|-------------------------|:-------------------------|:-------------------------|:------------------------- ![medium severity](https://res.cloudinary.com/snyk/image/upload/w_20,h_20/v1561977819/icon/m.png 'medium severity') | **631/1000**
**Why?** Proof of Concept exploit, Has a fix available, CVSS 6.2 | Missing Release of Resource after Effective Lifetime
[SNYK-JS-INFLIGHT-6095116](https://snyk.io/vuln/SNYK-JS-INFLIGHT-6095116) | Yes | Proof of Concept (\*) Note that the real score may have changed since the PR was raised.
Commit messages
Package name: expo The new version differs by 250 commits.
  • d6515f1 Publish packages
  • 307cf34 Update yarn.lock
  • 27cf58c [packages] Bump dependencies
  • 613b62c fix(cli): resolve real path of entry file for `export:embed` (#28926)
  • cf47931 fix(cli): parse npm view tarball objects instead of strings (#28919)
  • db2a6d6 [notifications][iOS] Add support for `interruptionLevel` (#28921)
  • 722e5a4 [updates] fix fingerprint policy start error on debug build (#28912)
  • e168ecf [docs] Update video.mdx (#28922)
  • 8c6a639 [cli] update `cacache` dependency (#28322)
  • 014faf7 [ios][camera] Correct orientation when taking landscape pictures (#28917)
  • 9e0fd00 [workspace] Update blog link (#28914)
  • ce82d01 [ios][camera] Prevent crash when rendered on the simulator (#28911)
  • 2cf0578 [docs] Add a link to alternate methods to enable developer mode (#28905)
  • dfab420 [templates] Publish latest [skip ci]
  • ec256db Publish packages
  • 82b5a4a Publish packages
  • ccc44e9 [tools] Assigning SDK tags also on the main branch (#28894)
  • 7777f63 [launcher][Android] Remove unnecessary reload when opening backgrounded app from icon (#28893)
  • 8e9717b [image-picker][Android] Add support for granular permissions (#28897)
  • bdf1688 [docs] Add explanation about using `--template` option in Get started tutorial (#28880)
  • 6da4825 [fingerprint] introduce fingerprint.config.js support (#28860)
  • 55e4ad4 [expo-notifications][Android] Get notification responses when app in background or not running (#28883)
  • 5d32712 [keep-awake] Stop useKeepAwake calls deactivating each other by default. (#28884)
  • 1a9913d [av][web] Fix should `shouldCorrectPitch` not working on web (#28837)
See the full diff
Check the changes in this PR to ensure they won't cause issues with your project. --- **Note:** _You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs._ For more information: 🧐 [View latest project report](https://app.snyk.io/org/expensify/project/a75415c0-01a0-4906-abb8-070d86e05d58?utm_source=github&utm_medium=referral&page=fix-pr) 🛠 [Adjust project settings](https://app.snyk.io/org/expensify/project/a75415c0-01a0-4906-abb8-070d86e05d58?utm_source=github&utm_medium=referral&page=fix-pr/settings) 📚 [Read more about Snyk's upgrade and patch logic](https://support.snyk.io/hc/en-us/articles/360003891078-Snyk-patches-to-fix-vulnerabilities) [//]: # 'snyk:metadata:{"customTemplate":{"variablesUsed":[],"fieldsUsed":[]},"dependencies":[{"name":"expo","from":"50.0.4","to":"51.0.8"}],"env":"prod","issuesToFix":[{"exploit_maturity":"Proof of Concept","id":"SNYK-JS-INFLIGHT-6095116","priority_score":631,"priority_score_factors":[{"type":"exploit","label":"Proof of Concept","score":107},{"type":"fixability","label":true,"score":214},{"type":"cvssScore","label":"6.2","score":310},{"type":"scoreVersion","label":"v1","score":1}],"severity":"medium","title":"Missing Release of Resource after Effective Lifetime"},{"exploit_maturity":"Proof of Concept","id":"SNYK-JS-INFLIGHT-6095116","priority_score":631,"priority_score_factors":[{"type":"exploit","label":"Proof of Concept","score":107},{"type":"fixability","label":true,"score":214},{"type":"cvssScore","label":"6.2","score":310},{"type":"scoreVersion","label":"v1","score":1}],"severity":"medium","title":"Missing Release of Resource after Effective Lifetime"},{"exploit_maturity":"Proof of Concept","id":"SNYK-JS-INFLIGHT-6095116","priority_score":631,"priority_score_factors":[{"type":"exploit","label":"Proof of Concept","score":107},{"type":"fixability","label":true,"score":214},{"type":"cvssScore","label":"6.2","score":310},{"type":"scoreVersion","label":"v1","score":1}],"severity":"medium","title":"Missing Release of Resource after Effective Lifetime"}],"prId":"3c6d45f5-4b56-4100-b2e5-8b63f0335b8e","prPublicId":"3c6d45f5-4b56-4100-b2e5-8b63f0335b8e","packageManager":"npm","priorityScoreList":[631],"projectPublicId":"a75415c0-01a0-4906-abb8-070d86e05d58","projectUrl":"https://app.snyk.io/org/expensify/project/a75415c0-01a0-4906-abb8-070d86e05d58?utm_source=github&utm_medium=referral&page=fix-pr","prType":"fix","templateFieldSources":{"branchName":"default","commitMessage":"default","description":"default","title":"default"},"templateVariants":["updated-fix-title","pr-warning-shown","priorityScore"],"type":"auto","upgrade":["SNYK-JS-INFLIGHT-6095116"],"vulns":["SNYK-JS-INFLIGHT-6095116"],"patch":[],"isBreakingChange":true,"remediationStrategy":"vuln"}' --- **Note:** _This is a default PR template raised by Snyk. Find out more about how you can customise Snyk PRs in our [documentation.](https://docs.snyk.io/scan-using-snyk/snyk-open-source/automatic-and-manual-prs-with-snyk-open-source/customize-pr-templates-closed-beta)_ **Learn how to fix vulnerabilities with free interactive lessons:** 🦉 [Learn about vulnerability in an interactive lesson of Snyk Learn.](https://learn.snyk.io/?loc=fix-pr)
melvin-bot[bot] commented 1 month ago

This is a Snyk issue. Snyk is a tool that automatically tracks our repositories' dependencies and reports associated security vulnerabilities. It also automatically create PRs to fix these vulnerabilities.

    C+: Please follow these steps to test the linked PR before running through the reviewer checklist:
    - [ ] The first step is to understand the PR: what dependency is it upgrading, for which vulnerability, how it impacts our product & end users.
    - [ ] If the issue is not worth fixing, please add your reasoning in the issue and have the internal engineer review it.
    - [ ] Check the change log (which should be included in the PR description) to see all changes. We want to identify any breaking changes. If it is a minor version bump, it's unlikely that there are any breaking changes.
    - [ ] Test our feature(s) that make use of this package. If it does not work, we should understand what broke it. It is also a good idea to check our main flows to make sure they are not broken that you can add in the checklist screenshots/videos.
melvin-bot[bot] commented 1 month ago

Triggered auto assignment to Contributor Plus for review of internal employee PR - @sobitneupane (Internal)

sobitneupane commented 4 weeks ago

@bondydaa Looks like this issue is related to this PR. Should we close this issue?

melvin-bot[bot] commented 3 days ago

This issue has not been updated in over 15 days. @sobitneupane eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!