Open tienifr opened 2 weeks ago
@shubham1206agra Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]
@shubham1206agra Please help review this PR
@tienifr Merge main please.
@tienifr I am unable to add new line in New Room description. Can you fix this?
@shubham1206agra
@tienifr Merge main please.
I merged main
@tienifr I am unable to add new line in New Room description. Can you fix this?
Can you share the recording? I still can add a new line.
@shubham1206agra I still can use cmd+enter to add a new line.
@shubham1206agra I still can use cmd+enter to add a new line.
@tienifr This will not work. We require to Enter or Shift + Enter to give a new line too.
@shubham1206agra Can you check this?
Details
Fixed Issues
$ https://github.com/Expensify/App/issues/41919 PROPOSAL: https://github.com/Expensify/App/issues/41919#issuecomment-2109828822
Tests
@ApplauseTester++0411km @jaihanumanblog@gmail.com
Tap header
Paste text in room description
Note second mention is highlighted
Note now second mention is highlighted and displayed
Offline tests
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
https://github.com/Expensify/App/assets/113963320/16b6adeb-e0ef-4c92-9001-c69d9d57d7afiOS: mWeb Safari
MacOS: Chrome / Safari
https://github.com/Expensify/App/assets/113963320/ffaf5571-b588-465d-a9cd-842a29d921f1MacOS: Desktop