Closed s77rt closed 1 day ago
Hey! I see that you made changes to our Form component. Make sure to update the docs in FORMS.md accordingly. Cheers!
@ikevin127 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]
### Fixed Issues
section aboveTests
sectionQA steps
sectiontoggleReport
and not onIconClick
).myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components using Avatar
have been tested & I retested again)/** comment above it */
this
properly so there are no scoping issues (i.e. for onClick={this.submit}
the method this.submit
should be bound to this
in the constructor)this
are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this);
if this.submit
is never passed to a component event handler like onClick
)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG
)Avatar
is modified, I verified that Avatar
is working as expected in all cases)Design
label and/or tagged @Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test
steps.The group offline behaviour is being implemented in this PR https://github.com/Expensify/App/pull/41826
as my assumption is that none of the items should be grayed-out by simply going offline
That's correct, in your case you probably already had a queued request
On my list to get to. Still on a merge freeze I believe but prioritizing everything as it comes in. Thanks for your patience here.
I think we're off the merge freeze hence I think this is good for merge ? cc @marcaaron
Thank for the bump @ikevin127. Apologies, this fell off my radar!
The typescript (and lint) error is unrelated, it should be fixed here https://github.com/Expensify/App/pull/42808
Looks like the PR has been merged now if we want to merge main on this so the checks pass.
Tests 🚀
cc @marcaaron
Thanks y'all! Nice work here ❤️
:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.
cc @marcaaron
Details
Part of https://github.com/Expensify/App/issues/40187
Fixed Issues
$ https://github.com/Expensify/App/issues/40187 PROPOSAL:
Tests
Test 1 (Renaming a group chat):
/settings/name
Test 2 (Renaming a room):
/settings/name
Offline tests
Same as Tests
QA Steps
Same as Tests
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
https://github.com/Expensify/App/assets/16493223/f3a1399b-0622-40cd-9b66-9aad127c577bAndroid: mWeb Chrome
Networking issueiOS: Native
https://github.com/Expensify/App/assets/16493223/501eb8fe-9663-469d-81ae-e8a715efb289iOS: mWeb Safari
https://github.com/Expensify/App/assets/16493223/4c147f4c-f21c-4172-b3c5-50561073b516MacOS: Chrome / Safari
https://github.com/Expensify/App/assets/16493223/57b0d0a5-4c99-4731-803a-f43b43227407MacOS: Desktop
https://github.com/Expensify/App/assets/16493223/8796dde3-14a6-4413-b3b7-affab86c51f0