[HOLD for payment 2024-07-17] [Payment card / Subscription] Integrate failed billing scenarios banner with backend data

[amyevans]

Design doc

Issue Owner

Current Issue Owner: @miljakljajic

[pasyukevich]

Hi, I'm Eugene from Callstack - expert agency - and I would like to work on this issue.

[amyevans]

Not overdue

[pasyukevich]

Today's updates - WIP, implementing utils file to handle all predefined error cases

[pasyukevich]

Today's updates - WIP, implementing utils file to handle all predefined error cases

[pasyukevich]

Today's updates - WIP, still implementing utils file to handle all predefined error cases

[amyevans]

Just cross-posting from here so that the message does not get lost: let's ensure to include the RBR implementation for when switching between plans is disallowed (failed UpdateSubscriptionType API command) in this PR

[pasyukevich]

Today's updates - WIP, Utils file is mostly done, remained - to glue logic with buttons, add error cases from failed API commands

[pasyukevich]

For the next two weeks I will be OOO, on Monday will be decided who will continue to work on this task

[amyevans]

Reassigning to @blimpich since I'm headed out on extended leave after today

[JKobrynski]

Hi, I'm Julian from Callstack - expert agency - and I would like to work on this issue.

[melvin-bot[bot]]

@blimpich, @JKobrynski Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[neil-marcellini]

Coming from the PR review and without reading the whole doc, it's really hard to know what the P/S is of this issue. What does it mean to integrate with backend data @blimpich?

[blimpich]

Basically there's a bunch of different failure states that can happen with the payment card and there is a decision-tree-like logic to how the UI should look based on the combination of data from the backend.

We parallelized the work for this project so that the frontend didn't have to wait for the backend apis to exist before getting merged, but that left us with the cleanup work of gluing the frontend to the backend once both were in place.

Though I'm confused as to why you got pullerBear-ed, I think we should have a C+ review this before any Expensify engineer gets into it.

[blimpich]

Adding @mananjadhav as they'll be the C+ reviewing the PR

[MrMuzyk]

Coming from the PR review and without reading the whole doc, it's really hard to know what the P/S is of this issue. What does it mean to integrate with backend data @blimpich?

The title is also a bit misleading, it's not only integrating with backend (making actual API call). Scope also includes adding this Retry payment button as it's not present yet

[melvin-bot[bot]]

@mananjadhav, @blimpich, @JKobrynski Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[mananjadhav]

Reviewed the PR again sometime back.

[trjExpensify]

PR merged yesterday, adding labels to get a BZ assigned.

[melvin-bot[bot]]

Triggered auto assignment to @miljakljajic (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

[melvin-bot[bot]]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot[bot]]

The solution for this issue has been :rocket: deployed to production :rocket: in version 9.0.5-13 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

• https://github.com/Expensify/App/pull/44072

If no regressions arise, payment will be issued on 2024-07-17. :confetti_ball:

For reference, here are some details about the assignees on this issue:

• @mananjadhav requires payment through NewDot Manual Requests
• @JKobrynski does not require payment (Contractor)

[melvin-bot[bot]]

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [ ] [@mananjadhav] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
• [ ] [@miljakljajic] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

[miljakljajic]

We pay you in ND right @mananjadhav ? So just a payment summary be due for this one on the 17th?

[mananjadhav]

Yes @miljakljajic that's right.