Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.13k stars 2.63k forks source link

[HOLD for payment 2024-07-17] [$250] [Payment card / Subscription] Integrate Retry billing button with backend data #42434

Open amyevans opened 1 month ago

amyevans commented 1 month ago

Design doc

Issue OwnerCurrent Issue Owner: @MrMuzyk
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~011654f2b733a74a09
  • Upwork Job ID: 1805295362253827219
  • Last Price Increase: 2024-06-24
web-cloudy commented 1 month ago

Hi Could you give me access?

melvin-bot[bot] commented 1 month ago

📣 @web-cloudy! 📣 Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork. Please follow these steps:

  1. Make sure you've read and understood the contributing guidelines.
  2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
  3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
  4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details. Screen Shot 2022-11-16 at 4 42 54 PM Format:
    Contributor details
    Your Expensify account email: <REPLACE EMAIL HERE>
    Upwork Profile Link: <REPLACE LINK HERE>
pasyukevich commented 1 month ago

Hi, I'm Eugene from Callstack - an expert agency - and I would like to work on this issue.

amyevans commented 1 month ago

Not overdue

JKobrynski commented 1 month ago

Hi, I'm Julian from Callstack - expert agency - and I would like to work on this issue.

amyevans commented 1 month ago

Reassigning to @blimpich since I'm headed out on extended leave after today

MrMuzyk commented 3 weeks ago

I am Michał from Callstack - expert contributor group. I’d like to work on this job.

I want to take over this from Julian as he hasn't started yet and he's taking over some stuff after Eugene :)

trjExpensify commented 3 weeks ago

Bumped this to Daily priority as we can work on it. :)

MrMuzyk commented 3 weeks ago

I'm still implementing it. It is somewhat blocked by https://github.com/Expensify/App/issues/42431 (need some utils, translations, updated components from there) but I've rebased with WIP that Julian is working on atm and Im doing what I can for now.

Tomorrow Im OOO and I will get back to it on friday. Hopefully by then #42431 will get merged and I will be fully unblocked

MrMuzyk commented 3 weeks ago

I've implemented what I can for now and left some questions on slack regarding the server response and happy path. PR will most likely be up on monday/tuesday

blimpich commented 3 weeks ago

Brought discussion to new slack thread.

MrMuzyk commented 2 weeks ago

Draft is up. Diff is much bigger than it will be once PR that is blocking me gets merged.

blimpich commented 2 weeks ago

Marking this as external so that the GH automations work correctly when the PR is opened for review.

melvin-bot[bot] commented 2 weeks ago

Job added to Upwork: https://www.upwork.com/jobs/~011654f2b733a74a09

melvin-bot[bot] commented 2 weeks ago

Triggered auto assignment to Contributor-plus team member for initial proposal review - @allroundexperts (External)

MrMuzyk commented 2 weeks ago

Still blocked but I've made same progress. I'm also making sure that PR that blocks me has everything I need and I'm ready for these changes on my end

MrMuzyk commented 2 weeks ago

Still blocked but keeping my draft up to date with dependant PR

MrMuzyk commented 2 weeks ago

Still blocked, tomorrow Im OOO so I will get back to it on monday. Hopefully I will be unblocked by then

MrMuzyk commented 1 week ago

Rebased draft PR. Still blocked

melvin-bot[bot] commented 4 days ago

Reviewing label has been removed, please complete the "BugZero Checklist".

melvin-bot[bot] commented 4 days ago

The solution for this issue has been :rocket: deployed to production :rocket: in version 9.0.5-13 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-07-17. :confetti_ball:

For reference, here are some details about the assignees on this issue: