[HIGH] Emails not delivering to invoice receivers

[davidcardoza]

Held on https://github.com/Expensify/App/issues/34167

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: Reproducible in staging?: Reproducible in production?: If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: Slack conversation:

Action Performed:

1. Login to demo account jagwarma1@gmail.com
2. send invoice to darnellwilkins51@gmail.com
3. Wait for email to darnellwilkins51@gmail.com inbox, never login to newdot using the account
4. No email is delivered

Expected Result:

An email should deliver with the invoice request

Actual Result:

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• [ ] Android: Native
• [ ] Android: mWeb Chrome
• [ ] iOS: Native
• [ ] iOS: mWeb Safari
• [ ] MacOS: Chrome / Safari
• [ ] MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~019b97b9a9d867b8b4
• Upwork Job ID: 1793269140957732864
• Last Price Increase: 2024-05-22

[melvin-bot[bot]]

Triggered auto assignment to @CortneyOfstad (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot[bot]]

Job added to Upwork: https://www.upwork.com/jobs/~019b97b9a9d867b8b4

[melvin-bot[bot]]

Triggered auto assignment to Contributor Plus for review of internal employee PR - @mollfpr (Internal)

[davidcardoza]

@robertjchen and @techievivek fixed this overnight I believe, but let's reopen if it's still happening.

[cristipaval]

Reopening, this is still happening for the invoice reports sent via NewDot.

[davidcardoza]

Yes, thank you.

[cristipaval]

Phew, I finally have something:

[cristipaval]

It was a challenge because, with the 1:1:1 initiative, I had to queue this notification from Auth. As you can see in the above screenshot, I still have to make tiny improvements. The PRs will be ready by Monday.

[cristipaval]

it will be ready for review today

[cristipaval]

Web-E PR ready for review. Auth PR is held on the Web-E PR

[CortneyOfstad]

Not overdue as the PR is ready for review!

CC @mollfpr

[cristipaval]

The PRs are actually on hold.

I'm trying to get here a consensus on how the email notifications should work for expense and invoice reports linked to workspace chats/invoice rooms.

[cristipaval]

Held on https://github.com/Expensify/App/issues/34167

[CortneyOfstad]

Thanks @cristipaval!

[CortneyOfstad]

Updated this to weekly to match the on-hold issue!

[cristipaval]

Still held

[CortneyOfstad]

PR is up!

[davidcardoza]

I am very excited for this!

[davidcardoza]

Any update on this issue?

[CortneyOfstad]

PR was deployed to staging 9 hours ago 🎉

[cristipaval]

That is the PR that this issue was held on. I've been busy getting a #wave-control urgent design doc out the door. I hope I'll get back to this issue tomorrow in the afternoon 🤞

[CortneyOfstad]

@cristipaval any update on this? Thanks!

[cristipaval]

Aiming to have the PRs ready for review at the end of today

[CortneyOfstad]

Thank you @cristipaval!

[cristipaval]

The PRs are ready for review. BUT the intro is not yet added to the email when the first invoice is sent. I need some time to implement it the right way, and I don't have that time now unfortunately.

[CortneyOfstad]

No worries and thank you @cristipaval! Just a heads up, I am OoO until Tuesday (July 9th) but if anything pops up in the meantime, feel free to add the bug label so there is no delay. Thanks!

[melvin-bot[bot]]

@CortneyOfstad, @cristipaval, @mollfpr Huh... This is 4 days overdue. Who can take care of this?

[cristipaval]

PR is still in review.

[CortneyOfstad]

Thanks Cristi!

[cristipaval]

I got some change requests on the Web-E PR. I'll do my best to address them asap.