[$250] Category - First item in the search result is not highlighted when parent category is selected

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.75-0 Reproducible in staging?: Y Reproducible in production?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4571713 Logs: https://stackoverflow.com/c/expensify/questions/4856 Issue reported by: Applause-Internal team

Action Performed:

Precondition:

• Workspace has a regular category, parent category and category in Parent: Child format.

1. Go to staging.new.expensify.com
2. Go to workspace chat.
3. Go to + > Submit expense > Manual.
4. Proceed to confirmation page.
5. Click Category.
6. Select a regular category.
7. Click Category.
8. Search for the regular category via search field.
9. Note that the first item in the search result is highlighted.
10. Select a parent category (not the child category).
11. Repeat Step 7 to 8.

Expected Result:

When parent category is selected, the first item in the search result will be highlighted when searching for it.

Actual Result:

When parent category is selected, the first item in the search result is not highlighted when searching for it.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• [x] Android: Native
• [x] Android: mWeb Chrome
• [x] iOS: Native
• [x] iOS: mWeb Safari
• [x] MacOS: Chrome / Safari
• [x] MacOS: Desktop

Screenshots/Videos

https://github.com/Expensify/App/assets/115492554/cc299973-a075-47f9-acc5-eab96eb1730b

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01f99c23349d15f2f1
• Upwork Job ID: 1795534731844476928
• Last Price Increase: 2024-06-04
• Automatic offers:
• tienifr | Contributor | 102601877

Issue Owner

Current Issue Owner: @Ollyws

[melvin-bot[bot]]

Triggered auto assignment to @greg-schroeder (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[izarutskaya]

We think this issue might be related to the #collect project.

[cretadn22]

@greg-schroeder Can you assist in providing instructions for creating subcategories?

[tienifr]

Proposal

Please re-state the problem that we are trying to solve in this issue.

When parent category is selected, the first item in the search result is not highlighted when searching for it.

What is the root cause of that problem?

• In here, we do not check whether the item is added to the selectedOptions before. Leads to selectedOptions can be 2.

• Then in here , because flattenedSections.selectedOptions.length !== prevSelectedOptionsLength, so the focused index is set to -1, so the first item in search result is not highlighted.

  What changes do you think we should make in order to solve the problem?

• In here we need to check if the item is added to selectedOptions before, if true, do nothing.

What alternative solutions did you explore? (Optional)

NA

[melvin-bot[bot]]

@greg-schroeder Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot[bot]]

Job added to Upwork: https://www.upwork.com/jobs/~01f99c23349d15f2f1

[melvin-bot[bot]]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Ollyws (External)

[greg-schroeder]

Adding to #wave-collect as this is definitely functionality that came up via the old wave 6

[Ollyws]

@tienifr's proposal LGTM. 🎀👀🎀 C+ reviewed

[melvin-bot[bot]]

Triggered auto assignment to @lakchote, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[lakchote]

@tienifr's proposal LGTM.

[greg-schroeder]

Okay I think you should assign them then, yes? @lakchote

[melvin-bot[bot]]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[melvin-bot[bot]]

@Ollyws, @lakchote, @greg-schroeder Eep! 4 days overdue now. Issues have feelings too...

[melvin-bot[bot]]

📣 @tienifr 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link Upwork job Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻 Keep in mind: Code of Conduct | Contributing 📖

[greg-schroeder]

I am assigning you @tienifr as you were selected above

[tienifr]

@Ollyws PR https://github.com/Expensify/App/pull/43093 is ready

[greg-schroeder]

Nice work, PR in review

[tienifr]

@lakchote Can you help review the PR? It is straightforward.

[tienifr]

Can we let another internal review the PR, it is very straightforward. Maybe @lakchote is not available or needs to focus on others.

[tienifr]

@greg-schroeder Hi could you check the above ^. PR testing and review is done, just pending internal approval for nearly 3 weeks.

[greg-schroeder]

Ah, shoot, Lucien is on parental leave, sorry about that. I'll request a new engineer to review

[tienifr]

@greg-schroeder Hi, did anyone volunteer on this? 😄 We're so close.

[greg-schroeder]

No, I'll ping again

[greg-schroeder]

@dangrous has taken over PR review