search

Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.55k stars 2.89k forks source link

[$500] Room mention - Room mention is highlighted when different room is created from whisper #42637

Closed lanitochka17 closed 3 months ago

lanitochka17 commented 5 months ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.4.76 Reproducible in staging?: Y Reproducible in production?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: N/A Issue reported by: Applause - Internal Team

Issue found when executing PR https://github.com/Expensify/App/issues/40857

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to any room
  3. Mention a non-existing room (#hello) and send it
  4. Edit the message in Step 3 and add another word right behind the room mention (#helloworld)
  5. Save the edit
  6. Click Yes on the whisper room creation message

Expected Result:

The new room mention in edit message in Step 4 will not be highlighted because the mentioned room is different from the room created from the whisper

Actual Result:

The first half of the room mention is highlighted when the room mention is different

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/Expensify/App/assets/78819774/72c34807-6fe8-4325-8382-78249d5c5b3d

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01c628cdc0c39c744f
  • Upwork Job ID: 1798161042106114048
  • Last Price Increase: 2024-08-05
Issue OwnerCurrent Issue Owner: @allgandalf
allgandalf commented 3 months ago

bump @anmurali for ^

melvin-bot[bot] commented 3 months ago

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

melvin-bot[bot] commented 3 months ago

@anmurali, @allgandalf Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

anmurali commented 3 months ago

This is on VIP VSB, which itself is paused at the moment. So let's close this issue for now and reopen down the line when we're prioritizing chat.