[$250] IOU - Payment turns into Submitted expense for a short time

lanitochka17 commented 5 months ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.4.76-5 Reproducible in staging?: Y Reproducible in production?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: N/A Issue reported by: Applause - Internal Team

Action Performed:

Log in as a Gmail account
Navigate to FAB - Pay someone
Enter any amount
Enter a new Gmail address without an Expensify account
Create the IOU

Expected Result:

It should remain as a paid IOU

Actual Result:

Payment turns into Submitted expense. It reverts back in a few seconds if you open the IOU or refresh the page

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/Expensify/App/assets/78819774/180de32b-e892-497d-97f1-407b3d0f470b

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01b66ef1fd86c13a9c
Upwork Job ID: 1795517213267488768
Last Price Increase: 2024-05-28

melvin-bot[bot] commented 5 months ago

Triggered auto assignment to @greg-schroeder (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

lanitochka17 commented 5 months ago

@greg-schroeder FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

melvin-bot[bot] commented 5 months ago

Job added to Upwork: https://www.upwork.com/jobs/~01b66ef1fd86c13a9c

melvin-bot[bot] commented 5 months ago

Triggered auto assignment to Contributor-plus team member for initial proposal review - @jjcoffee (External)

alexrasla commented 5 months ago

Proposal

Please re-state the problem that we are trying to solve in this issue.

The problem we are trying to solve here is that sometimes when we "Pay Someone" with an email account that is not registered with Expensify, we run into a bug that causes the text to say owes instead of paid after some time.

What is the root cause of that problem?

The root cause of this problem is that the latest report data is not being read from the Onxy data store. The report read from the allReports here is outdated when read, saying that the Onxy report has a statusNum: 1 (REPORT.STATUS_NUM.OPEN), and thus rendering the default text of iou.payerOwes. However, if we read the latest stored data in the Onxy report, the statusNum would be 4 (REPORT.STATUS_NUM.REIMBURSED), which would cause the ReportUtils.isSettled function to return true, and thus returns the correct iou.payerPaid text here.

What changes do you think we should make in order to solve the problem?

In order to solve this problem, we just need to read the latest Onxy report data when checking if the report isSettled here. Once we have the latest data from the Onxy store, the statusNum will be 4 and will equal REPORT.STATUS_NUM.REIMBURSED, and the correct paid text will show on the UI.

What alternative solutions did you explore? (Optional)

I explored changing the isSettled to also check if report.statusNum == REPORT.STATUS_NUM.OPEN, but that doesn't seem to make logical sense to see if a report is settled.

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

jjcoffee commented 5 months ago

Pretty sure this is a BE issue as the IOU displays correctly initially and then turns into a submitted expense once the SendMoneyElsewhere call completes. SendMoneyElsewhere returns an onyx update that sets the report to submitted:

{
"stateNum": 1,
"statusNum": 1,
}

cc @greg-schroeder