[Hold for Payment 2024-09-03][$250] [Pending/Scanning] The count of expenses on a report is not calculating correctly for card transactions

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.77-4 Reproducible in staging?: need reproduction Reproducible in production?: need reproduction If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: @kevinksullivan Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1717026569202759

Details on simulating card transactions below

Action Performed:

1. Set up workspace and enable workflows
2. Navigate to workflows and enable approvals
3. Assign expensify card to a member on that workspace
4. Incur a card transaction
5. Incur another card transaction

Expected Result:

The expense count should show as total# expenses (x scanning, y pending)

Actual Result:

The expense count is 0

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• [ ] Android: Native
• [ ] Android: mWeb Chrome
• [ ] iOS: Native
• [ ] iOS: mWeb Safari
• [x] MacOS: Chrome / Safari
• [ ] MacOS: Desktop

Screenshots/Videos

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0179ad48857375d973
• Upwork Job ID: 1810354497668334430
• Last Price Increase: 2024-08-19

Issue Owner

Current Issue Owner: @getusha

[melvin-bot[bot]]

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[MelvinBot]

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

[kevinksullivan]

added another datapoint here

https://expensify.slack.com/archives/C049HHMV9SM/p1717089079785199?thread_ts=1717026569.202759&cid=C049HHMV9SM

[mallenexpensify]

Internal since you need a card to test. @trjExpensify , I added to  #wave-collect and set status as Release 2 (since the roadmap doc said 'card support' was then)

[trjExpensify]

Yep! CC: @kevinksullivan @grgia

[mallenexpensify]

Waiting to get picked up internally

[melvin-bot[bot]]

@mallenexpensify this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[mallenexpensify]

@trjExpensify what's the (project) priority for this? Considering how hard I want to push to find an internal volunteer. Thx

[trjExpensify]

Pending/Scanning is high for the summer release. This pending/scanning project is still in dev, so I'm not sure if @grgia's recent work will catch this or it needs to be looked into separately. If it's a frontend issue, I wonder if there's instructions for a contributor to simulate pending card transactions on dev to test we could provide.

[grgia]

Is this still reproducible? This most likely is a FE issue

[grgia]

Assigning to keep track of this for now

[mallenexpensify]

Posted in #expensify-open-source

Does anyone know if we have instructions for a contributor to simulate pending card transactions on dev? I couldn't find anything in SO or searching this room (it's for this GH) (edited)

Also threw retest-weekly since QA might be able to confirm reproduction more easily.

[melvin-bot[bot]]

Unable to auto-create job on Upwork. The BZ team member should create it manually for this issue.

[melvin-bot[bot]]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @getusha (External)

[mallenexpensify]

Since it looks like this might be FE, I'm going to open it up. Deets on simulating card transactions is here in the #expensify-open-source Slack room

[melvin-bot[bot]]

Job added to Upwork: https://www.upwork.com/jobs/~0179ad48857375d973

[melvin-bot[bot]]

Current assignee @getusha is eligible for the External assigner, not assigning anyone new.

[mallenexpensify]

Posted in #qa asking for a retest https://expensify.slack.com/archives/C9YU7BX5M/p1720457243115109

[grgia]

@mallenexpensify could you send an update of where we're at with this issue?

[mallenexpensify]

Convo in #qa got derailed a bit cuz of

In short words. Our test account that is linked to our Expensify card is taking a LOT to load in New Expensify.

Checking again about the retest.

[isagoico]

I'm not able to reproduce this issue on my side.

The correct amount of pending expenses was displayed in the preview.

[mallenexpensify]

@kevinksullivan can you test again to see if you're able to repro? I'm unsure how to test cards

[melvin-bot[bot]]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[grgia]

waiting on retest

[kevinksullivan]

here is another example:

There are only 6 expenses on the report, and only one is shown as pending.

This is on kevin@expensify.com

Here is the report in OldDot

ReportID: R00U97HvvgOn

[grgia]

Hmm weird, let's see how we're calculating these

[melvin-bot[bot]]

@mallenexpensify, @grgia, @getusha Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot[bot]]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[mallenexpensify]

Hmm weird, let's see how we're calculating these

@grgia , any update on the above?

[grgia]

I haven't had a chance to look at this one yet, I'm OOO thurs/fri but will be able to make any required internal changes on Monday.

@getusha are you able to confirm whether this is a FE or BE bug?

[getusha]

Will look into this first thing tomorrow!

[trjExpensify]

@getusha did you confirm if this is a frontend or backend bug?

[melvin-bot[bot]]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[melvin-bot[bot]]

@mallenexpensify, @grgia, @getusha Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[getusha]

@getusha did you confirm if this is a frontend or backend bug?

Following the dev steps i wasn't able to reproduce it, it's showing me the correct amount of pending cards, It might be a BE issue if it still persists with a real card.

https://github.com/user-attachments/assets/9b000f93-75e0-4bde-9172-0fa5f960b3f6

cc @grgia

[mallenexpensify]

Posted in the Slack thread to check to see who else is using the card for real world transactions, ie. free lunch

[grgia]

@mallenexpensify yeah if we can test this with a real card that would be great.

[mallenexpensify]

if we can test this with a real card that would be great.

@grgia any idea how to do this? I'm more than fine with buying some candy for the bank on my Expensify card, I'm unsure if that'd help here cuz of the first two steps

1. Set up workspace with no approvals configured
2. Assign expensify card to a member on that workspace

If it needs to be a new workspace and card, how do we even go about that?

[trjExpensify]

Tagged you in the thread Kevin responded to you.

[mallenexpensify]

Thanks Tom, hadn't caught Kev's comment in the thread yet. I'll see what i can do tomorrow.

FWIW, anyone can test the card transactions on @cardtest.expensify.com . That is how I would recreate this with a workspace that has no approvals.

[mallenexpensify]

Checking on in thread

for @cardtest.expensify.com , do you have more details or a link for how that works? I see the How do I test the Expensify Card on staging or production? SO which states

For now, we are using fake expensify.com accounts, for example you can ask a domain admin to invite ionatan+cardtest@expensify.com and use that account to test it.

Is it as simple as creating a GH to get mallen+cardtest@expensify.com invited then to request a card through New or OldDot?

Found this SO too which might be helpful too I need to test making a real Expensify Card transaction, what do I do?

[mallenexpensify]

Checking here

I need to test an expensify card that only has a $5 limit, does anyone know where I can make multiple micro transactions so I can get multiple pending transactions?

Tried a few spots without luck. Will keep thinking.

[mallenexpensify]

Got the card setup and made 3 transactions via Paypal, using this SO, but I forgot to create the workspace first so I'm seeing everything in "your space"

[melvin-bot[bot]]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[melvin-bot[bot]]

@mallenexpensify, @grgia, @getusha Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[grgia]

I think this is because we are counting the outdated transaction objects. We need to either 1) delete the old parent transaction from ONYX entirely (reportID is set to -4) or filter these out.

[mallenexpensify]

Still struggling to reproduce this bug. Just now followed the steps in the OP

1. Set up workspace and enable workflows
2. Navigate to workflows and enable approvals
3. Assign expensify card to a member on that workspace
4. Incur a card transaction
5. Incur another card transaction

This is what I see

[grgia]

Looking into this https://expensify.slack.com/archives/C036QM0SLJK/p1723032031245939?thread_ts=1723021882.407309&cid=C036QM0SLJK

[mallenexpensify]

I've tried testing using Paypal twice and haven't been able to reproduce. I thought I might be able to test today, by purchasing three items at a coffee shop on my Expensify Card but it's not showing in NewDot, only OldDot :/

I 'hacked' my way into view it in NewDot via the report ID, 7857663122685204, and in Safari and the transactions are showing as 3 separate.

[trjExpensify]

I thought I might be able to test today, by purchasing three items at a coffee shop on my Expensify Card but it's not showing in NewDot, only OldDot :/

That workspace isn't supported officially on NewDot yet, because it's our Inc policy.