[$250] Next steps are incorrect when there is no approval on a report

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.77-3 Reproducible in staging?: y Reproducible in production?: y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: @kevinksullivan Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1717026958410769

Action Performed:

1. Set up workspace with no approvals configured
2. assign expensify card to a member on that workspace
3. Incur a card transaction

Expected Result:

The next steps read should show:

Header: "Finished!" Subheader: "No further action required!"

Actual Result:

Next steps say this report needs approval.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• [ ] Android: Native
• [ ] Android: mWeb Chrome
• [ ] iOS: Native
• [ ] iOS: mWeb Safari
• [x] MacOS: Chrome / Safari
• [ ] MacOS: Desktop

Screenshots/Videos

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~017287c932cce9e705
• Upwork Job ID: 1797365106853683200
• Last Price Increase: 2024-08-08
• Automatic offers:
• alitoshmatov | Reviewer | 103271393

[melvin-bot[bot]]

Triggered auto assignment to @MitchExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot[bot]]

Job added to Upwork: https://www.upwork.com/jobs/~017287c932cce9e705

[melvin-bot[bot]]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @alitoshmatov (External)

[MitchExpensify]

What do you think the header should say @kevinksullivan ? Something like this?;

"Waiting for approval."

[melvin-bot[bot]]

@MitchExpensify, @alitoshmatov Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot[bot]]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[melvin-bot[bot]]

@MitchExpensify, @alitoshmatov 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

[MitchExpensify]

Going to make a call and suggest we remove next steps entirely in this situation so I've updated the OP accordingly.

Waiting on proposals at this point 👀

[MitchExpensify]

What wave collect status do you think this one fits under @trjExpensify ?

[trjExpensify]

Hm, is this part of the pending/scanning implementation? @kevinksullivan didn't we talk about this one using the "finished" terminology for the closed non-reimbursable reports?

[melvin-bot[bot]]

@MitchExpensify, @alitoshmatov Now this issue is 8 days overdue. Are you sure this should be a Daily? Feel free to change it!

[MitchExpensify]

Bumping Slack thread here https://expensify.slack.com/archives/C049HHMV9SM/p1718225472265049?thread_ts=1717026958.410769&cid=C049HHMV9SM

[melvin-bot[bot]]

@MitchExpensify @alitoshmatov this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[MitchExpensify]

Updated the expected behavior based on the slack conversation

We need proposals now

[melvin-bot[bot]]

@MitchExpensify, @alitoshmatov 10 days overdue. I'm getting more depressed than Marvin.

[melvin-bot[bot]]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[MitchExpensify]

I feel like this might be hot pick worthy, what d'you reckon @trjExpensify ?

[alitoshmatov]

assign expensify card to a member on that workspace

I think we are not going to have any proposals since it requires expensify card

[trjExpensify]

I feel like this might be hot pick worthy, what d'you reckon @trjExpensify ?

It's external isn't it? @grgia any idea how someone can use dev to simulate what we're asking for here in the OP?

[grgia]

@trjExpensify I believe this is known cc @kevinksullivan

but the solution is to not soley base next steps off of report state, since the report can be in processing state and not require next steps. For this case, we would also want to check if the report has only non reimbursable transactions

[trjExpensify]

@trjExpensify I believe this is known cc @kevinksullivan

As in, there's another issue for it? This is an issue that was reported by Kevin, so maybe it's this?

[melvin-bot[bot]]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[melvin-bot[bot]]

@MitchExpensify, @grgia, @alitoshmatov Huh... This is 4 days overdue. Who can take care of this?

[MitchExpensify]

Yeah I think this is the only issue for this after a search

[grgia]

I think this is an internal issue, we likely need to update the nextSteps for this report to be finished if the report contains only non-reimbursable expenses. Next steps were implemented in the Drafts project. cc @mountiny if you have any quick input on where we'd need to add that check

@kevinksullivan @trjExpensify what is the expected header for this? / Does it also depend on policy type?

[mountiny]

@grgia is this only optimistic issue? So when we load the next steps from server its correct?

If its coming incorrect from the server this is already an OldDot issue that we would need to fix in Web (same next steps would show up in oldDot)

[trjExpensify]

Looking at the screenshot in the OP:

Both of those transactions on the report look like they're pending, so should the expected results really be to use the "Finished" next steps in this case?

In the doc it looks like we have a specific next step message for that case, which I would assume we want to copy to the report level when all expenses on the report are pending transactions?

@kevinksullivan it might be an idea if you could just list out the next steps and the cases in this issue for the expected results.

[MitchExpensify]

Not overdue, Melvin - Actively being worked on.

[mountiny]

In the doc it looks like we have a specific next step message for that case, which I would assume we want to copy to the report level when all expenses on the report are pending transactions?

I think those still have to be added, I dont see them in the NextStep in Web, not even for the expense level.

That being said, I think we are not using the expense level next steps in Newdot. So you would have to add it to the report level to show it

[melvin-bot[bot]]

@MitchExpensify @grgia @alitoshmatov this issue is now 4 weeks old, please consider:

• Finding a contributor to fix the bug
• Closing the issue if BZ has been unable to add the issue to a VIP or Wave project
• If you have any questions, don't hesitate to start a discussion in #expensify-open-source

Thanks!

[melvin-bot[bot]]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[grgia]

I think we are not using the expense level next steps in Newdot. So you would have to add it to the report level to show it

@mountiny could you expand on this?

[grgia]

bump on above @mountiny

[mountiny]

@grgia in OldDot, you can have 2 next steps messages. One is shown in the expense report level and another next step information can be shown in the detail of transaction/ expense.

There are not many of these expenseMessages; you can see one here, for example.

We only show the nextStep.message in Newdot, not the expenseMessage

I think to show this message in the transaction thread we should not use report next steps, but rather use logic that tells us that the expense is still pending to show this message.

[melvin-bot[bot]]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[MitchExpensify]

Did that resolve your question @grgia ? Do we need anything else at this point to solicit proposals based on the OP?

[grgia]

@MitchExpensify nothing is blocking proposals as is

[melvin-bot[bot]]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[grgia]

waiting for proposals melvin

[MitchExpensify]

Reassigning as I'm heading on leave imminently 🙇

[melvin-bot[bot]]

Triggered auto assignment to @anmurali (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot[bot]]

@anmurali, @grgia, @alitoshmatov Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot[bot]]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[grgia]

open for proposals

[pasyukevich]

Hi, I'm Eugene from Callstack - expert contributor group. I’d like to work on this issue.

[trjExpensify]

Assigned!

[melvin-bot[bot]]

📣 @alitoshmatov 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link Upwork job

[grgia]

@pasyukevich thanks for taking this one! Let me know if you need anything

[pasyukevich]

@grgia Could you please provide more details on how to reproduce this issue? I was able to add a card to the workspace without needing approval and successfully submitted an expense. However, I do not see the next steps text here. Maybe I am missing something.

[melvin-bot[bot]]

@anmurali, @pasyukevich, @grgia, @alitoshmatov Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!