[HOLD for payment 2024-07-22] [HOLD for payment 2024-07-17] [$250] Workspace chat - Unable to remove member from workspace chat

lanitochka17 commented 2 months ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.4.78-0 Reproducible in staging?: Y Reproducible in production?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: N/A Issue reported by: Applause - Internal Team

Action Performed:

Go to staging.new.expensify.com
Go to Account Settings > Workspace > click on a workspace > Invite Member > Invite a test account as a member
Go to workspace chat
Click on the chat header
Go to Members
Remove the new users - verify you see the "removed" notification in the chat
Notice the list of members is greater than the number of members (as if the removed member wasn't removed)

Expected Result:

User should be able to remove a member from the workspace The member count should match the number of members

Actual Result:

When refreshing the browser the user isn't removed from the Members list The member count isn't accurate

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/Expensify/App/assets/78819774/906149cf-779d-4b36-941e-fc57936a01f7

https://github.com/Expensify/App/assets/51066321/efab0564-171d-4456-ba8d-135b82650f4c

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01008c963ec6d29d78
Upwork Job ID: 1798248796400459776
Last Price Increase: 2024-06-05

Issue Owner

Current Issue Owner: @Christinadobrzyn / @Christinadobrzyn

Issue Owner

Current Issue Owner: @strepanier03 / @Christinadobrzyn

jasperhuangg commented 2 months ago

@techievivek Although I think this is technically a regression from working on https://github.com/Expensify/App/issues/35391, I think we should allow the original PR's author to handle it.

cc @brunovjk

brunovjk commented 2 months ago

You're right @jasperhuangg, here I added (isPolicyExpenseChat && isAdmin), but I missed checking for owner and auditors, I assumed that all of these had an admin role.

(isPolicyExpenseChat && ( isAdmin || isOwner || isAuditor )) should solve it. I'll investigate further, but do you have an idea how we intend isAuditor?

techievivek commented 2 months ago

@techievivek You can still invite people to the workspace chat who weren't in it by default (i.e. you can invite people other than the owner, admins, and auditors). So we still want the ability to remove the people who weren't in the workspace chat by default.

Oh, nice, I wasn't aware of this; thanks for clarifying it.

tienifr commented 2 months ago

I think @tienifr's proposal to disable the option if we see the accountID matching the workspace chat's owner should suffice.

@jasperhuangg @techievivek Since I spent quite some time investigating this and post a proposal after the request from @techievivek.

I'd appreciate if we can move forward with it here if it looks good 🙇

jasperhuangg commented 2 months ago

@brunovjk thanks for clarifying.

We currently don't have auditors in NewDot yet (AFAIK), but I think you'd just check if their policy role is auditor.

In any case I do think @tienifr's proposal should solve this issue so I'm gonna move forward with assigning them.

techievivek commented 2 months ago

Looks like automation is borked here.

strepanier03 commented 2 months ago

Thanks for assigning them @techievivek 🙌

Christinadobrzyn commented 1 month ago

Update for Melvin - working on PR - https://github.com/Expensify/App/pull/44595

Christinadobrzyn commented 1 month ago

PR is merged to staging - almost there!

melvin-bot[bot] commented 1 month ago

Reviewing label has been removed, please complete the "BugZero Checklist".

melvin-bot[bot] commented 1 month ago

The solution for this issue has been :rocket: deployed to production :rocket: in version 9.0.5-13 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

https://github.com/Expensify/App/pull/44595

If no regressions arise, payment will be issued on 2024-07-17. :confetti_ball:

For reference, here are some details about the assignees on this issue:

@jayeshmangwani requires payment through NewDot Manual Requests
@tienifr requires payment through NewDot Manual Requests

melvin-bot[bot] commented 1 month ago

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[ ] [@jayeshmangwani] The PR that introduced the bug has been identified. Link to the PR:
[ ] [@jayeshmangwani] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[ ] [@jayeshmangwani] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[ ] [@jayeshmangwani] Determine if we should create a regression test for this bug.
[ ] [@jayeshmangwani] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[ ] [@strepanier03 / @Christinadobrzyn] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

melvin-bot[bot] commented 1 month ago

The solution for this issue has been :rocket: deployed to production :rocket: in version 9.0.6-8 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

https://github.com/Expensify/App/pull/44595

If no regressions arise, payment will be issued on 2024-07-22. :confetti_ball:

For reference, here are some details about the assignees on this issue:

@jayeshmangwani requires payment through NewDot Manual Requests
@tienifr requires payment through NewDot Manual Requests

melvin-bot[bot] commented 1 month ago

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[ ] [@jayeshmangwani] The PR that introduced the bug has been identified. Link to the PR:
[ ] [@jayeshmangwani] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[ ] [@jayeshmangwani] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[ ] [@jayeshmangwani] Determine if we should create a regression test for this bug.
[ ] [@jayeshmangwani] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[ ] [@strepanier03 / @Christinadobrzyn] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

Christinadobrzyn commented 1 month ago

preparing for payment

Payouts due:

[ ] Contributor: $250 @tienifr (payment through New Expensify)
[ ] Contributor+: $250 @jayeshmangwani (payment through New Expensify)

Any payment for @bernhardoj? I see they started on this and then it looks like we transitioned in another direction?

Let us know about a regression test @jayeshmangwani

jayeshmangwani commented 1 month ago

[x] [@jayeshmangwani] The PR that introduced the bug has been identified. Link to the PR: https://github.com/Expensify/App/pull/43065
[x] [@jayeshmangwani] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/43065#discussion_r1681596906
[x] [@jayeshmangwani] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
[x] [@jayeshmangwani] Determine if we should create a regression test for this bug. Yes
[x] [@jayeshmangwani] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression Test Proposal

Add a new member to a workspace
Go to the workspace chat created for that member
Press report details -> Members
Verify you cannot remove that member from the workspace chat

Do we agree 👍 or 👎

strepanier03 commented 1 month ago

@Christinadobrzyn - I didn't realize we were both assigned to this until I'd already done the the reg test so that parts is finished 😂.

strepanier03 commented 1 month ago

It doesn't look like @bernhardoj is due payment so I think we can just post the payment summary for this.

strepanier03 commented 1 month ago

Payment Summary

Contributor: $250 @tienifr (payment through New Expensify)
Contributor+: $250 @jayeshmangwani (payment through New Expensify)

@JmillsExpensify - Two requests incoming via New Expensify.

melvin-bot[bot] commented 1 month ago

Payment Summary

Upwork Job

Reviewer: @jayeshmangwani owed $250 via NewDot
Reviewer: @tienifr owed $250 via NewDot

BugZero Checklist (@JmillsExpensify)

[x] I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
[x] I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1798248796400459776/hired) ~- [ ] I have paid out the Upwork contracts or cancelled the ones that are incorrect~
[x] I have verified the payment summary above is correct

melvin-bot[bot] commented 1 month ago

@JmillsExpensify, @strepanier03, @jayeshmangwani, @techievivek, @Christinadobrzyn, @tienifr Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

Christinadobrzyn commented 1 month ago

I think we can close this since payment will be through New Expensify-

NewDot Payment summary - https://github.com/Expensify/App/issues/42928#issuecomment-2239839946 Regression test - https://github.com/Expensify/Expensify/issues/413575

jayeshmangwani commented 1 month ago

Requested $250

JmillsExpensify commented 1 month ago

$250 approved for @jayeshmangwani

JmillsExpensify commented 3 weeks ago

$250 approved for @tienifr

Expensify / App