search

Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.11k stars 2.61k forks source link

Unable to remove users/ user from the Workplace #4299

Closed isagoico closed 2 years ago

isagoico commented 2 years ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Action Performed:

  1. Launch the app
  2. Click on FAB menu
  3. New Workspace
  4. Click on Get Started!
  5. Select People
  6. Invite 3 users to your workspace
  7. Select one of the users/ user and Click Remove
  8. Click Remove button on the Remove Members popup

Expected Result:

Able to remove users/ user from the Workplace

Actual Result:

Unable to remove users/ user from the Workplace

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platform:

Where is this issue occurring?

Version Number: 1.0.81-1

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos:

https://user-images.githubusercontent.com/44479856/127514178-3daee5b5-7bcd-4650-8b6f-7a4db58e4896.mp4

Expensify/Expensify Issue URL:

View all open jobs on Upwork

MelvinBot commented 2 years ago

Triggered auto assignment to @johnmlee101 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

Jag96 commented 2 years ago

I can reproduce this one, the error being returned from the API is Invalid email address parameter because for some reason the emailList value is an empty string when sending from iOS but not from web. We're currently sending an array of strings to the API, but in the Web repo for the same command we send a comma-separated list of emails. The API expects a comma-separated list as well, so I'll make a PR to send a comma-separated list to the API instead of an array.

MelvinBot commented 2 years ago

@Jag96 Whoops! This issue is 2 days overdue. Let's get this updated quick!

Jag96 commented 2 years ago

This has the reviewing label so Melvin shouldn't be pinging, but also this is on production so closing