Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.39k stars 2.79k forks source link

[$250] mWeb - chat - Quote markdown is shown differently while sending and editing #43053

Closed lanitochka17 closed 1 month ago

lanitochka17 commented 4 months ago

If you havenโ€™t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.79 Reproducible in staging?: Y Reproducible in production?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4594014 Issue reported by: Applause - Internal Team

Action Performed:

  1. Go to https://staging.new.expensify.com/
  2. Tap on a report
  3. Enter >>>>>
  4. Note the message after markdown applied
  5. Send the message
  6. Long press the message and open edit comment

Expected Result:

Quote markdown must be displayed same while sending and editing

Actual Result:

Quote markdown is shown differently while sending and editing

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/Expensify/App/assets/78819774/b4f71bfd-1927-481e-abca-c9cc6877911f

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0162cb2f380985d8c5
  • Upwork Job ID: 1799109600952906182
  • Last Price Increase: 2024-08-09
Issue OwnerCurrent Issue Owner: @garrettmknight
melvin-bot[bot] commented 4 months ago

Triggered auto assignment to @garrettmknight (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

lanitochka17 commented 4 months ago

We think that this bug might be related to #vip-vsp

dragnoir commented 3 months ago

Proposal

Please re-state the problem that we are trying to solve in this issue.

Quote markdown is shown differently while sending and editing

What is the root cause of that problem?

Expensify common package is not updated, there are new changes to the logic inside ExpensiMark.js that should be integrated.

https://github.com/Expensify/App/blob/a67be2f7037cab40d6fe7affd88c5f569b0afc75/package.json#L114

What changes do you think we should make in order to solve the problem?

We need to update Expensify-common package to the lastest update

https://github.com/Expensify/App/blob/a67be2f7037cab40d6fe7affd88c5f569b0afc75/package.json#L114

POC:

https://github.com/Expensify/App/assets/12425932/6ef228a6-6e00-4871-a570-436092a12f4c

What alternative solutions did you explore?

melvin-bot[bot] commented 3 months ago

Job added to Upwork: https://www.upwork.com/jobs/~0162cb2f380985d8c5

melvin-bot[bot] commented 3 months ago

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mkhutornyi (External)

melvin-bot[bot] commented 3 months ago

@garrettmknight, @mkhutornyi Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

garrettmknight commented 3 months ago

@mkhutornyi can you review the proposal above?

mkhutornyi commented 3 months ago

@dragnoir can you please retest? expensify-common was already updated to latest version

mkhutornyi commented 3 months ago

Awaiting proposals

melvin-bot[bot] commented 3 months ago

๐Ÿ“ฃ It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? ๐Ÿ’ธ

garrettmknight commented 3 months ago

Still awaiting proposals.

melvin-bot[bot] commented 3 months ago

@garrettmknight @mkhutornyi this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

garrettmknight commented 3 months ago

Still awaiting proposals.

melvin-bot[bot] commented 3 months ago

๐Ÿ“ฃ It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? ๐Ÿ’ธ

garrettmknight commented 3 months ago

Still awaiting proposals

melvin-bot[bot] commented 3 months ago

๐Ÿ“ฃ It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? ๐Ÿ’ธ

garrettmknight commented 3 months ago

Still awaiting proposals

garrettmknight commented 3 months ago

Still awaiting proposals

melvin-bot[bot] commented 3 months ago

@garrettmknight @mkhutornyi this issue is now 4 weeks old, please consider:

Thanks!

mvtglobally commented 3 months ago

Issue is reproducible during KI retests.

https://github.com/Expensify/App/assets/43995119/f3e0b529-1315-46fa-925a-df06637a61fc

mkhutornyi commented 3 months ago

Issue is still reproducible with:

>>>> test
image image
garrettmknight commented 2 months ago

Still awaiting proposals

melvin-bot[bot] commented 2 months ago

๐Ÿ“ฃ It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? ๐Ÿ’ธ

garrettmknight commented 2 months ago

Still awaiting proposals

garrettmknight commented 2 months ago

Still awaiting proposals

melvin-bot[bot] commented 2 months ago

๐Ÿ“ฃ It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? ๐Ÿ’ธ

garrettmknight commented 2 months ago

Still awaiting proposals

garrettmknight commented 2 months ago

Still awaiting proposals

garrettmknight commented 2 months ago

Still awaiting proposals, also dropping to weekly. I don't think this worth upping the price even if we still want to leave it open to complete.

melvin-bot[bot] commented 2 months ago

๐Ÿ“ฃ It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? ๐Ÿ’ธ

melvin-bot[bot] commented 2 months ago

๐Ÿ“ฃ It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? ๐Ÿ’ธ

melvin-bot[bot] commented 2 months ago

๐Ÿ“ฃ It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? ๐Ÿ’ธ

garrettmknight commented 1 month ago

No update, still waiting for proposals.

mvtglobally commented 1 month ago

Issue not reproducible during KI retests. (First week)

melvin-bot[bot] commented 1 month ago

๐Ÿ“ฃ It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? ๐Ÿ’ธ

garrettmknight commented 1 month ago

Will test next week

garrettmknight commented 1 month ago

Couldn't reproduce either. Closing.