[HOLD for payment 2024-06-28] [HOLD for payment 2024-06-24] [$250] iOS - System chat - Chat with your setup specialist message not aligned and gets out of box

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

issue reproducible when validating #41290 Version Number: 1.4.79-6 Reproducible in staging?: y Reproducible in production?: no, (the chat is not displayed to check) If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: Applause internal team Slack conversation:

Action Performed:

1. Open the app and log in with a new account
2. Select Manage my teams expenses on onboarding modal
3. Complete the onboarding flow
4. Tap the search icon
5. Open Expensify chat

Expected Result:

The message "Chat with your specialist in #admins for help" is displayed in the box

Actual Result:

The message flows out of the box. Changing device font size might help reproduce the issue.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• [ ] Android: Native
• [ ] Android: mWeb Chrome
• [x] iOS: Native
• [ ] iOS: mWeb Safari
• [ ] MacOS: Chrome / Safari
• [ ] MacOS: Desktop

Screenshots/Videos

https://github.com/Expensify/App/assets/38435837/efe243ea-6d4a-4738-844c-9f6fc09c7320

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01572a633b7213a3b7
• Upwork Job ID: 1798353544964635137
• Last Price Increase: 2024-06-05
• Automatic offers:
• shubham1206agra | Reviewer | 102686779
• bernhardoj | Contributor | 102686780

Issue Owner

Current Issue Owner: @MitchExpensify / @MitchExpensify

Issue Owner

Current Issue Owner: @puneetlath / @MitchExpensify

[melvin-bot[bot]]

Triggered auto assignment to @puneetlath (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot[bot]]

Triggered auto assignment to @MitchExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[github-actions[bot]]

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[m-natarajan]

FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[puneetlath]

I don't think it needs to block the deploy, but let's fix it.

[melvin-bot[bot]]

Job added to Upwork: https://www.upwork.com/jobs/~01572a633b7213a3b7

[melvin-bot[bot]]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @shubham1206agra (External)

[ShridharGoel]

Proposal

Please re-state the problem that we are trying to solve in this issue.

System chat - Chat with your setup specialist message not aligned and gets out of box

What is the root cause of that problem?

There is no padding in the below text which is passed as content to Banner:

https://github.com/Expensify/App/blob/66b4072db8ec86a8eed2d6e765a52eae3c9c68d4/src/pages/home/report/SystemChatReportFooterMessage.tsx#L67-L75

What changes do you think we should make in order to solve the problem?

Add some horizontal padding below:

content={<Text style={[styles.pr4]}
                           suppressHighlighting>{content}</Text>}

Padding details need to be discussed with design team.

Optional:

Update this to the below to show text only if it is defined:

{(() => {
    if (!text) {
        return null;
    }
    if (shouldRenderHTML) {
        return <RenderHTML html={text} />;
    }
    return (
        <Text
            style={[styles.flex1, styles.flexWrap, textStyles]}
            onPress={onPress}
            suppressHighlighting
        >
            {text}
        </Text>
    );
})()}

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The report system chat footer gets out of the box.

What is the root cause of that problem?

The container itself already sets a padding, https://github.com/Expensify/App/blob/66b4072db8ec86a8eed2d6e765a52eae3c9c68d4/src/components/Banner.tsx#L74-L78

but the text content still overflows the banner/box. If we look at the banner text, we apply a flex1 style that should fix this issue, https://github.com/Expensify/App/blob/66b4072db8ec86a8eed2d6e765a52eae3c9c68d4/src/components/Banner.tsx#L99-L105

but in our case, we use custom text content which doesn't have the flex1 style. https://github.com/Expensify/App/blob/66b4072db8ec86a8eed2d6e765a52eae3c9c68d4/src/components/Banner.tsx#L94 https://github.com/Expensify/App/blob/66b4072db8ec86a8eed2d6e765a52eae3c9c68d4/src/pages/home/report/SystemChatReportFooterMessage.tsx#L73

What changes do you think we should make in order to solve the problem?

Add styles.flex1 style to the content. https://github.com/Expensify/App/blob/66b4072db8ec86a8eed2d6e765a52eae3c9c68d4/src/pages/home/report/SystemChatReportFooterMessage.tsx#L73

Then, make sure to not render the Text component if the text is empty. https://github.com/Expensify/App/blob/66b4072db8ec86a8eed2d6e765a52eae3c9c68d4/src/components/Banner.tsx#L96-L106

{shouldRenderHTML && text ? (
    <RenderHTML html={text} />
) : text && (
    ...

[ShridharGoel]

Proposal

Updated to include optional item.

[melvin-bot[bot]]

📣 @ssswhite0707! 📣 Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork. Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details. Format:

   Contributor details
   Your Expensify account email: <REPLACE EMAIL HERE>
   Upwork Profile Link: <REPLACE LINK HERE>

[Krishna2323]

Proposal

Please re-state the problem that we are trying to solve in this issue.

iOS - System chat - Chat with your setup specialist message not aligned and gets out of box

What is the root cause of that problem?

This is a known issue in react native and is caused by using flexRow on parent view of a Text element. https://github.com/Expensify/App/blob/198b47360fa6fa5bfbb81f3fb535a2fa6817e375/src/components/Banner.tsx#L85 https://github.com/Expensify/App/blob/198b47360fa6fa5bfbb81f3fb535a2fa6817e375/src/components/Banner.tsx#L94

From SystemChatReportFooterMessage we pass the content prop, which is a Text component. https://github.com/Expensify/App/blob/198b47360fa6fa5bfbb81f3fb535a2fa6817e375/src/pages/home/report/SystemChatReportFooterMessage.tsx#L73

What changes do you think we should make in order to solve the problem?

• Inside Banner.tsx we need to wrap the content coming from the prop in a View which has flex1 style applied. Also make sure to not render the view when content is not present.

  {content && <View style={styles.flex1}>{content}</View>}

• Do not render RenderHTML or Text when text is not present.

  {text &&
  (shouldRenderHTML ? (
      <RenderHTML html={text} />
  ) : (
      <Text
          style={[styles.flex1, styles.flexWrap, textStyles]}
          onPress={onPress}
          suppressHighlighting
      >
          {text}
      </Text>
  ))}

What alternative solutions did you explore? (Optional)

[MitchExpensify]

@shubham1206agra what do you think of these proposals?

[melvin-bot[bot]]

@puneetlath, @MitchExpensify, @shubham1206agra Huh... This is 4 days overdue. Who can take care of this?

[MitchExpensify]

Bump @shubham1206agra, thanks

[MitchExpensify]

Waiting on a review on proposals, Melvin

[shubham1206agra]

I will go ahead with @bernhardoj's proposal since he was the first to give the correct solution.

🎀👀🎀 C+ reviewed

[melvin-bot[bot]]

Current assignee @puneetlath is eligible for the choreEngineerContributorManagement assigner, not assigning anyone new.

[melvin-bot[bot]]

📣 @shubham1206agra 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link Upwork job

[melvin-bot[bot]]

📣 @bernhardoj 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link Upwork job Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻 Keep in mind: Code of Conduct | Contributing 📖

[bernhardoj]

PR is ready

cc: @shubham1206agra

[melvin-bot[bot]]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot[bot]]

The solution for this issue has been :rocket: deployed to production :rocket: in version 1.4.84-3 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

• https://github.com/Expensify/App/pull/43479

If no regressions arise, payment will be issued on 2024-06-24. :confetti_ball:

For reference, here are some details about the assignees on this issue:

• @bernhardoj requires payment automatic offer (Contributor)
• @shubham1206agra requires payment automatic offer (Reviewer)

[melvin-bot[bot]]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [ ] [@shubham1206agra] The PR that introduced the bug has been identified. Link to the PR:
• [ ] [@shubham1206agra] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [ ] [@shubham1206agra] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [ ] [@shubham1206agra] Determine if we should create a regression test for this bug.
• [ ] [@shubham1206agra] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [ ] [@MitchExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[MitchExpensify]

Reminder set to pay - Do we need BZ steps here @shubham1206agra ?

[melvin-bot[bot]]

The solution for this issue has been :rocket: deployed to production :rocket: in version 1.4.85-7 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

• https://github.com/Expensify/App/pull/43479

If no regressions arise, payment will be issued on 2024-06-28. :confetti_ball:

For reference, here are some details about the assignees on this issue:

• @bernhardoj requires payment automatic offer (Contributor)
• @shubham1206agra requires payment automatic offer (Reviewer)

[melvin-bot[bot]]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [ ] [@shubham1206agra] The PR that introduced the bug has been identified. Link to the PR:
• [ ] [@shubham1206agra] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [ ] [@shubham1206agra] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [ ] [@shubham1206agra] Determine if we should create a regression test for this bug.
• [ ] [@shubham1206agra] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [ ] [@MitchExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[shubham1206agra]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [x] [@shubham1206agra] The PR that introduced the bug has been identified. Link to the PR: https://github.com/Expensify/App/pull/40010
• [x] [@shubham1206agra] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/40010/files#r1660544412
• [x] [@shubham1206agra] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: NA
• [x] [@shubham1206agra] Determine if we should create a regression test for this bug. No
• [x] [@shubham1206agra] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [ ] [@MitchExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[shubham1206agra]

@MitchExpensify Bump on the payment here.

[MitchExpensify]

Paid and contracts ended!