Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.42k stars 2.8k forks source link

Workspace - QuickBooks bill payment account option is missing #43132

Closed lanitochka17 closed 3 months ago

lanitochka17 commented 4 months ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.79-7 Reproducible in staging?: Y Reproducible in production?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: N/A Email or phone of affected tester (no customers): applausetester+shuss@applause.expensifail.com Issue reported by: Applause - Internal Team

Issue found when executing PR https://github.com/Expensify/App/pull/42561

Action Performed:

  1. Connect Workspace to QBO but not sync
  2. Go to Workspace > Accounting
  3. Click on Advanced > QuickBooks bill payment account
  4. Verify that if there is no account to select then a message "No accounts found" is displayed

Expected Result:

QuickBooks bill payment account option should be displayed

Actual Result:

QuickBooks bill payment account option is missing

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/Expensify/App/assets/78819774/8d0c38b9-048a-4c96-9f43-7445fada4a74

View all open jobs on GitHub

melvin-bot[bot] commented 4 months ago

Triggered auto assignment to @alexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

lanitochka17 commented 4 months ago

@alexpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

lanitochka17 commented 4 months ago

We think that this bug might be related to #wave-collect - Release 1

kavimuru commented 4 months ago

@hayata-suenaga tagging you per this comment

hayata-suenaga commented 4 months ago

This section, right?

Screenshot 2024-06-05 at 4 39 18 PM
hayata-suenaga commented 4 months ago

I think these two rows (bill payment account and invoice collection account) only appear when you toggle on the "Sync reimbursed reports"

https://github.com/Expensify/App/assets/98560306/e8a5219f-7551-4f5c-9c9d-ce3fba439674

In your testing, the sync option is off.

Screenshot 2024-06-05 at 4 49 00 PM
hayata-suenaga commented 4 months ago

Asked for retest in the #qa Slack channel

alexpensify commented 4 months ago

@hayata-suenaga - can you please Slack link to follow along? Thanks!

hayata-suenaga commented 4 months ago

sorry 🙇 here is the link 😄

kavimuru commented 3 months ago

@hayata-suenaga if data not sync after connected to QBO then not able to turned it on if data synced then after turning that on these section displayed

https://github.com/Expensify/App/assets/43996225/dfe2e3be-edac-49c8-9ce7-0fb1b5d7baf9

hayata-suenaga commented 3 months ago

ah this is the same issue we're dealing with here -> https://github.com/Expensify/App/issues/43130

hayata-suenaga commented 3 months ago

Discussing about this type of issues in Slack

alexpensify commented 3 months ago

There was a recent update, so I've bumped the 🧵 to confirm what we should do here.

aldo-expensify commented 3 months ago

The Web-E part of this has not been deployed yet: https://github.com/Expensify/Web-Expensify/pull/42292, I think we can wait for that

alexpensify commented 3 months ago

@aldo-expensify this went into production yesterday. What's the plan for this GH? Thanks for the update!

aldo-expensify commented 3 months ago

we have to just test if the mentioned issue is reproducible, if it is not, we close

aldo-expensify commented 3 months ago

Tested fine in production:

image
alexpensify commented 3 months ago

Woo, thanks @aldo-expensify!