search

Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.1k stars 2.6k forks source link

[Live Markdown] Styling for empty nested block quotes #43199

Open thienlnam opened 3 weeks ago

thienlnam commented 3 weeks ago

Corresponds with https://github.com/Expensify/App/issues/41107

Inserting a nested empty block quote breaks the styling

The paddings for the nested blockquotes are causing height differences between the containers, and the min-height of the container isn't set, so when we try to insert empty blockquotes, we end up with the situation presented below.

image

cc @BrtqKr

melvin-bot[bot] commented 3 weeks ago

Triggered auto assignment to @anmurali (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

thienlnam commented 3 weeks ago

@BrtqKr Is this something you'd like to handle or shall we make it external?

BrtqKr commented 3 weeks ago

@thienlnam I can take over this, thanks for letting me know!

BrtqKr commented 3 weeks ago

Update for today: I've got most of the changes, but the empty lines are a bit tricky to handle, so I'm trying to fix it at the moment.

BrtqKr commented 3 weeks ago

Update for today: Draft is ready for the review from someone from SWM and we'll be passing it further soon. Also, there are some styling changes in the core app, but since getting rid of the margins completely is probably out of question I'm looking for a workaround

melvin-bot[bot] commented 1 week ago

@anmurali @BrtqKr this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!