[HOLD for payment 2024-06-24] [$125] [Search v1] Search page: Show dates for prior year transactions

[JmillsExpensify]

Problem

We're on the cusp of launching a v1 Search page, which means it's possible to see transactions from prior years. What I mean by this is that we are now in 2024, and I have a transaction I can find on the Search from back in 2017. The issue is that I have no idea looking at the transaction that it's from that far back.

Here's the New Expensify transaction.

Here's the Expensify Classic transaction

Solution

When looking at a prior year transaction, show the year, in addition to the month and date.

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~017440ce6c14aca464
• Upwork Job ID: 1798793329608614800
• Last Price Increase: 2024-06-06
• Automatic offers:
• dukenv0307 | Reviewer | 102671230
• ShridharGoel | Contributor | 102671233

Issue Owner

Current Issue Owner: @greg-schroeder

[melvin-bot[bot]]

Triggered auto assignment to @greg-schroeder (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

[JmillsExpensify]

P.S. We're going to need web and mobile mocks from the design team. I reached out to them.

[luacmartins]

@Expensify/design would love your ideas on how to display this

[shawnborton]

I'm thinking it might be best to just make the column wider:

Because it doesn't look nearly as good if we stack like OldDot:

Mobile seems pretty straight forward:

[melvin-bot[bot]]

Job added to Upwork: https://www.upwork.com/jobs/~017440ce6c14aca464

[melvin-bot[bot]]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @dukenv0307 (External)

[melvin-bot[bot]]

Upwork job price has been updated to $125

[JmillsExpensify]

Looks dope! I'll go ahead and take this so we can open up to community. cc @luacmartins

[JmillsExpensify]

Ah...haha you beat me to it.

[ShridharGoel]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Search page: Show dates for prior year transactions

What is the root cause of that problem?

New change.

What changes do you think we should make in order to solve the problem?

Change column width to w96 at this place:

columnWidth = getWidthStyle(variables.w80);

Change the date format at this place:

const date = TransactionUtils.getCreated(transactionItem, CONST.DATE.MONTH_DAY_YEAR_ABBR_FORMAT);

[dannymcclain]

I agree we should just keep it simple and make the column wider.

[dukenv0307]

Let's go with @ShridharGoel's solution. In the meantime, can you confirm what the width should be? Is w96 good? @dannymcclain @shawnborton

🎀👀🎀 C+ reviewed

[melvin-bot[bot]]

Current assignee @luacmartins is eligible for the choreEngineerContributorManagement assigner, not assigning anyone new.

[shawnborton]

@ShridharGoel why use 96 for the column width? In the mockup we're using 80.

[ShridharGoel]

I think I don't have access to that mockup where the width is mentioned, so I added a 96 as a suggestion. Can you link it?

Edit: Updated it to 80 now.

[shawnborton]

Perfect, 80 is all you need so you should be good there.

[dukenv0307]

@luacmartins wdyt about my decision above? Thanks

[trjExpensify]

@mountiny can you keep this moving? We might be able to get it today. :)

[melvin-bot[bot]]

📣 @dukenv0307 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link Upwork job

[melvin-bot[bot]]

📣 @ShridharGoel 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link Upwork job Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻 Keep in mind: Code of Conduct | Contributing 📖

[mountiny]

Cool taking over, I think Carlos will have enough of other tasks

[trjExpensify]

Cool taking over, I think Carlos will have enough of other tasks

Nah, the guy barely works. :trollface:

[greg-schroeder]

PR is up/in review

[melvin-bot[bot]]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot[bot]]

The solution for this issue has been :rocket: deployed to production :rocket: in version 1.4.84-3 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

• https://github.com/Expensify/App/pull/43413

If no regressions arise, payment will be issued on 2024-06-24. :confetti_ball:

For reference, here are some details about the assignees on this issue:

• @ShridharGoel requires payment automatic offer (Contributor)
• @dukenv0307 requires payment automatic offer (Reviewer)

[melvin-bot[bot]]

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [ ] [@dukenv0307] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
• [ ] [@greg-schroeder] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

[ShridharGoel]

@luacmartins @mountiny Since the scope of this task had increased, do you think it qualifies for a normal bounty instead of 125 ?

[luacmartins]

@ShridharGoel I'm not sure that I understand how the scope increased. We still just added the year to the date column if there are transactions from previous years which was the OP, no?

[ShridharGoel]

@luacmartins I think initially it was decided that we'll just make the column wider, then it was concluded that we'll only make it wider if there's at least one transaction from a past year. Do let me know your thoughts on this.

[ShridharGoel]

@luacmartins What I mean mostly is that this wasn't a simple UI change and it involved significant logical changes. Though I'm happy with the existing bounty as well, just thought to discuss about how it is decided in such scenarios.

[luacmartins]

I think the OP was to add the year, which is where the logic change came from and definitely in scope. I think we would just keep the existing bounty as is.

[melvin-bot[bot]]

The solution for this issue has been :rocket: deployed to production :rocket: in version 1.4.85-7 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

• https://github.com/Expensify/App/pull/43413

If no regressions arise, payment will be issued on 2024-06-28. :confetti_ball:

For reference, here are some details about the assignees on this issue:

• @ShridharGoel requires payment automatic offer (Contributor)
• @dukenv0307 requires payment automatic offer (Reviewer)

[melvin-bot[bot]]

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [ ] [@dukenv0307] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
• [ ] [@greg-schroeder] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

[dukenv0307]

IMO, It would be fair to increase the bounty 125 - 250 as usual since there're many code changes and discussions cc @luacmartins @ShridharGoel

[luacmartins]

This was a simple change, so I think the current bounty of $125 is applicable here.

[shawnborton]

Not overdue, we're holding for payment

[luacmartins]

PR was deployed to prod on the 17th, so the payment due date is actually the 24th. cc @greg-schroeder

[melvin-bot[bot]]

@shawnborton, @luacmartins, @greg-schroeder, @ShridharGoel, @mountiny, @dukenv0307 Whoops! This issue is 2 days overdue. Let's get this updated quick!

[greg-schroeder]

Oh. Okay. I'll process this now then

[greg-schroeder]

@ShridharGoel please accept the offer in Upwork so I can pay you, thanks!

[greg-schroeder]

bump @ShridharGoel

[greg-schroeder]

Bump @ShridharGoel - moving this to Monthly given no response.

[ShridharGoel]

Accepted, thanks.

[luacmartins]

@greg-schroeder seems like the offer was accepted. Can we close this now?

[greg-schroeder]

Yes it does appear it was finally accepted! I'll close it after I confirm payment!

[greg-schroeder]

Paid