Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.44k stars 2.8k forks source link

[CRITICAL] UX RELIABILITY - Receipt is stuck in a scanning state and the expense fails to load when the IOU preview is tapped #43253

Closed muttmuure closed 2 months ago

muttmuure commented 4 months ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: v1.4.79-7 Reproducible in staging?: Reproducible in production?: If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: @davidcardoza Slack conversation: https://expensify.slack.com/archives/C05LX9D6E07/p1717631386394629

Action Performed:

  1. Open mobile app
  2. Got to new NewDot test workspace chat
  3. tap a IOU request with a receipt scanning in progress
  4. Wait several minutes, nothing loads
  5. Press back
  6. Tap a different IOU request
  7. IOU loads as expected

Expected Result:

The receipt loads immediately

Actual Result:

The loading skeleton loads infinitely

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @davidcardoza
melvin-bot[bot] commented 4 months ago

Triggered auto assignment to @MitchExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

muttmuure commented 3 months ago

Taking off hold

muttmuure commented 3 months ago

Going to ask Doza to try and reproduce

muttmuure commented 3 months ago

@davidcardoza I'm going to reassign this to you since it happened in your account.

Can you update to the latest version, turn on client side logs and then try to reproduce this?

davidcardoza commented 3 months ago

I was able to to access the mobile app. I've scanned two receipts, both are still scanning after 6 minutes. I will check back in a few hours.

tgolen commented 3 months ago

Note: This PR was released in version 1.4.82-4 yesterday to production. It should contain the additional logs that might help us track this down.

According to the logs I am looking at right now, there is a client here that has a broken sequential queue that keeps growing and never shrinking.

image

I need to get this client updated to at least version 1.4.82-4 of the app so that we can look at the new client logs that we added.

melvin-bot[bot] commented 3 months ago

Current assignee @tgolen is eligible for the AutoAssignerNewDotQuality assigner, not assigning anyone new.

tgolen commented 3 months ago

I've got a good logsearch query here:

blob:"Darwin/23.5.0" AND (blob:"[SequentialQueue]" OR blob:"[NetworkStatus]" OR blob:"[NetworkConnection]")

Now all I need is a specific window of time to look at. @davidcardoza can you please try a new smart scan and let me know the approximate time (and your timezone) that you made the requests?

tgolen commented 3 months ago

Weekly Update

Next Steps

ETA

davidcardoza commented 3 months ago

Now all I need is a specific window of time to look at. @davidcardoza can you please try a new smart scan and let me know the approximate time (and your timezone) that you made the requests?

Do you still need this?

tgolen commented 3 months ago

Nope! I found a good timeframe in the logs yesterday and found what I needed.

On Mon, Jun 24, 2024 at 4:22 PM David Cardoza @.***> wrote:

Now all I need is a specific window of time to look at. @davidcardoza https://github.com/davidcardoza can you please try a new smart scan and let me know the approximate time (and your timezone) that you made the requests?

Do you still need this?

— Reply to this email directly, view it on GitHub https://github.com/Expensify/App/issues/43253#issuecomment-2187510489, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJMAB6YJ2XXWJMBHFHWGZTZJCL25AVCNFSM6AAAAABI6MEO7CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOBXGUYTANBYHE . You are receiving this because you were mentioned.Message ID: @.***>

muttmuure commented 2 months ago

Looks like we're done with this one and it's fixed for Doza.