[$250] Assign Task - When changing Assignee, the page lags when closing modal

lanitochka17 commented 3 months ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.4.81-4 Reproducible in staging?: Y Reproducible in production?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: N/A Email or phone of affected tester (no customers): applausetester+emilio@applause.expensifail.com Issue reported by: Applause - Internal Team

Action Performed:

Open New Expensify App
Sign into a valid account (HT account is better for reproduction)
Create a Task and then click on the IOU
Change the Assignee and notice the page closing.

Expected Result:

User expects the page to close "clean"

Actual Result:

The page has a slight "lag/Delay" when closing, visible for a couple of seconds.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[x] MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/Expensify/App/assets/78819774/2c655493-f95d-4e0a-99f7-be2a7c0d4bba

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01794355bb64abf4a9
Upwork Job ID: 1800741657347973622
Last Price Increase: 2024-07-10
Automatic offers:

allgandalf | Reviewer | 103151963
truph01 | Contributor | 103151965

Issue Owner

Current Issue Owner: @allgandalf

MonilBhavsar commented 2 months ago

Yes! Thank you for checking

allgandalf commented 1 month ago

Still working on the PR, had one doubt, can you address that when you get time @MonilBhavsar

allgandalf commented 1 month ago

[x] The PR that introduced the bug has been identified. Link to the PR: https://github.com/Expensify/App/pull/35841
[x] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/35841/files#r1732183573
[x] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
[x] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression Test Proposal

Open App
Create a Task and then click on the IOU
Change the Assignee and notice the page closing.

Verify that the page closes without delay/lag

Do we agree 👍 or 👎

allgandalf commented 1 month ago

@JmillsExpensify , this is ready for payment 🙇

JmillsExpensify commented 1 month ago

Payment summary:

Contributor: @truph01 $250
Reviewer: @allgandalf $250

JmillsExpensify commented 1 month ago

All contributors paid out. I'm going to past on creating the regression test given the scale/type of bug, so closing this out!

Expensify / App