Expensify / App

Welcome to New Expensify: a complete re-imagination of financial collaboration, centered around chat. Help us build the next generation of Expensify by sharing feedback and contributing to the code.
https://new.expensify.com
MIT License
3.54k stars 2.88k forks source link

[Search v1] - Deleted expense is not removed from Search #43415

Closed m-natarajan closed 1 week ago

m-natarajan commented 5 months ago

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.81-1 Reproducible in staging?: y Reproducible in production?: no If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: applause internal team Slack conversation:

Action Performed:

Precondition:

  1. Go to staging.new.expensify.com
  2. Go to workspace chat.
  3. Submit an expense.
  4. Go to Search.
  5. Note that the submitted expense is shown.
  6. Go to workspace chat and delete the expense.
  7. Refresh the page.
  8. Go to Search.

Expected Result:

The deleted expense will be removed from Search.

Actual Result:

The deleted expense is not removed from Search. This issue is not reproducible with new account that doesn't have expenses.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

https://github.com/Expensify/App/assets/38435837/a0446077-cc4f-47dd-878b-bc1df1b58ead

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @luacmartins
melvin-bot[bot] commented 5 months ago

Triggered auto assignment to @blimpich (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

melvin-bot[bot] commented 5 months ago

Triggered auto assignment to @puneetlath (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

github-actions[bot] commented 5 months ago

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.
m-natarajan commented 5 months ago

@puneetlath FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

m-natarajan commented 5 months ago

We think that this bug might be related to #wave-collect - Release 1

luacmartins commented 5 months ago

This is expected for now.

luacmartins commented 5 months ago

Closing as a dupe of https://github.com/Expensify/App/issues/43382

luacmartins commented 4 months ago

It seems like this issue is still happening, so I'll reopen it.

melvin-bot[bot] commented 4 months ago

@puneetlath, @luacmartins Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

puneetlath commented 4 months ago

@luacmartins will you be tackling this yourself?

luacmartins commented 4 months ago

I think this is internal. Ideally we find a volunteer to tackle this, otherwise I can take a look as a lower priority issue.

luacmartins commented 4 months ago

Still waiting on volunteer

melvin-bot[bot] commented 3 months ago

@luacmartins Eep! 4 days overdue now. Issues have feelings too...

luacmartins commented 3 months ago

Still no volunteers. I'll look into this one later this week.

melvin-bot[bot] commented 3 months ago

@luacmartins Eep! 4 days overdue now. Issues have feelings too...

luacmartins commented 3 months ago

Same as above.

melvin-bot[bot] commented 3 months ago

@luacmartins Huh... This is 4 days overdue. Who can take care of this?

luacmartins commented 3 months ago

No updates yet. I'll start working on it this week.

melvin-bot[bot] commented 3 months ago

@luacmartins Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

luacmartins commented 3 months ago

Prioritizing other Search v2 issues

melvin-bot[bot] commented 3 months ago

@luacmartins Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

melvin-bot[bot] commented 2 months ago

@luacmartins 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

luacmartins commented 2 months ago

Prioritizing other Search v2 issues

melvin-bot[bot] commented 2 months ago

@luacmartins Eep! 4 days overdue now. Issues have feelings too...

luacmartins commented 2 months ago

Prioritizing other Search v2 issues

melvin-bot[bot] commented 2 months ago

@luacmartins Eep! 4 days overdue now. Issues have feelings too...

luacmartins commented 2 months ago

Prioritizing other Search v2 issues

melvin-bot[bot] commented 2 months ago

@luacmartins Eep! 4 days overdue now. Issues have feelings too...

luacmartins commented 2 months ago

Prioritizing other Search v2 issues

luacmartins commented 2 months ago

PR in review

melvin-bot[bot] commented 1 month ago

@luacmartins Eep! 4 days overdue now. Issues have feelings too...

melvin-bot[bot] commented 1 month ago

@luacmartins 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

melvin-bot[bot] commented 1 month ago

@luacmartins Now this issue is 8 days overdue. Are you sure this should be a Daily? Feel free to change it!

melvin-bot[bot] commented 1 month ago

@luacmartins 12 days overdue. Walking. Toward. The. Light...

melvin-bot[bot] commented 1 month ago

This issue has not been updated in over 14 days. @luacmartins eroding to Weekly issue.

melvin-bot[bot] commented 2 weeks ago

This issue has not been updated in over 15 days. @luacmartins eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

luacmartins commented 1 week ago

This is done