Open yuwenmemon opened 3 weeks ago
Triggered auto assignment to Contributor-plus team member for initial proposal review - @abdulrahuman5196 (External
)
Triggered auto assignment to @isabelastisser (NewFeature
), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.
Hey! I’m Jakub Szymczak from Software Mansion, an expert agency, and I’d like to work on this issue!
Update: I'll start working on this issue once I put up a PR on https://github.com/Expensify/App/issues/43532. Posting this so you know about my priorities.
Thanks for your update 👍
I'll be starting to work on this task tomorrow as I'm almost done with the Sage Intacct connection task.
@yuwenmemon, @hungvu193, @isabelastisser, @SzymczakJ Whoops! This issue is 2 days overdue. Let's get this updated quick!
Can we put this on hold for https://github.com/Expensify/App/issues/43532 🤔 so it won't get overdue
@SzymczakJ sounds like he'll be working on it tomorrow so no need to put a HOLD IMO.
Update: Started working on this, PR draft should be around in one/two days.
Update: still working on draft PR. By the way how is backend for this task looking? If I call Connections.updatePolicyConnectionConfig
(just like we did for Xero or QBO) with proper arguments will it work out of the box or do I need to wait for BE to implement it?
@yuwenmemon @hungvu193 can you please follow up on the question above? Thanks!
I think it should be similar with QBO and Xero. Let's wait for confirmation from Yuwen
@SzymczakJ As mentioned in the Design Doc we'll actually be adding individual API commands for each setting, which will require separate action method in the front-end.
They're described in detail in the doc I linked above. As for when they'll be available on production I believe @NikkiWines is actively working on the issue right now so I expect we start seeing them next week.
In the meantime let's build out the actions and use the descriptions of the APIs in the Design Doc so that it's plug-and-play when the APIs go live.
Still working on it
@yuwenmemon, @hungvu193, @isabelastisser, @SzymczakJ Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
Still In progress
Same
I should be able to take this PR out of draft on Monday.
PR will be ready for review today.
I got a review from @war-in, let me fix his comments and tomorrow the PR will be ready for your review @hungvu193 😄
PR ready for review. When testing keep in mind that some functionalities don't work and wait to be fixed on BE side:
Also ready for design team review. The visual part is presented in test steps of PR.
Thank you. I'll take a look today :🙋♂️
Tracking GH: https://github.com/Expensify/Expensify/issues/388780
Design doc section: https://docs.google.com/document/d/1k3ZFw8KB55yPUSCG6KYZlwpwEtmRt3eUshwxs7bZq5I/edit#heading=h.vc9skc4t3y4f
You will find in the following issue the pseudocode for the different flows. Use them as a guide in your implementation.
Import flow
Main page
Issue Owner
Current Issue Owner: @hungvu193